Minor bug fixes #165
Minor bug fixes #165
Conversation
Fix cache option presence checking When dumping json of a playlist, do not throw exception if the playlist has only some "erratic" videos and not all
|
|
||
| if (exitCode > 0) { | ||
| if (exitCode > 0 && (!json || (json && out.isEmpty()))) { |
There was a problem hiding this comment.
can this not be solved using --ignore-errors flag?
If not, maybe we should still throw exception if out is not a valid json.
There was a problem hiding this comment.
I see. I have to make some tests. About throwing an exception on invalid JSON, you are definitely right. I will try to make this part more robust.
There was a problem hiding this comment.
I have made one more test. --ignore-errors does not prevent ytdlp returning 1 and not 0 when having a single erratic video in a playlist.
We could change the condition as follows
if (exitCode > 0 && (!json || (json && (out.isEmpty() || !request.hasOption("--ignore-errors"))))) {For json sanity checking we could use the code inside getInfo. Obviously we should try to parse the output only if the above condition fails and exitCode is > 0. What do you think?
There was a problem hiding this comment.
This condition looks good. But maybe make it a little easier to read. Something like this with the remaining condition inside ignoreErrors function.
exitCode > 0 && !ignoreErrors(request, out)
We don't have to do the json sanity part because you added the --ignore-errors in the condition. That is good enough.
…dable and ignores exit codes grater than 0 honoring the --ignore-errors input switch
|
Now it should be OK. |
|
Looks good. Feel free to merge. |
Hi,
with this PR I am fixing some minor bug I found in the code. They are:
Keep last value of progress and ETA when parsing fails
Fix cache option presence checking
When dumping json of a playlist, do not throw exception if the playlist has only some "erratic" videos and not all
Thanks for your work.