Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stack.yaml to build with stack #2

Merged
merged 2 commits into from Oct 23, 2017
Merged

Add stack.yaml to build with stack #2

merged 2 commits into from Oct 23, 2017

Conversation

Tehnix
Copy link
Contributor

@Tehnix Tehnix commented Oct 19, 2017

No description provided.

@yav
Copy link
Owner

yav commented Oct 19, 2017

Hey, thanks for generating this, but could you prune it down a bit, so that it doesn't have all the auto generated gunk?

Also, I am not a stack expert, but why does it says that you need lts-9.9. I believe this package should also work with much older ones...

@Tehnix
Copy link
Contributor Author

Tehnix commented Oct 21, 2017

Ah, yeah, I've removed the autogenerated comments :) As for the LTS, it needs to be set to a specific one. It is merely for cloning down the repository and building the executable locally though, so it's not any concern as long as colorize-haskell is expected to work with the specific GHC versions that the LTS uses (in this case 8.0.2).

Also, I hope you didn't take offense by my asking if the repo was dead or anything, it was perhaps a bit too bluntly phrased, I just wanted to do an official poke to see if I could justify taking over as a stackage maintainer for this package, which I wouldn't mind :)

I can open a separate issue for this, but would you mind that I took responsibility for getting the package into stackage? The process is described here and doesn't entail any work on your part, just that I wanted you to be aware of it.

It would mean that for example ghc-core would be able to build directly from stackage/stack without having to add colorize-haskell as an extra-deps :)

@yav yav merged commit 8385bd0 into yav:master Oct 23, 2017
@yav
Copy link
Owner

yav commented Oct 23, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants