Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose Utils.hs as library #40

Merged
merged 3 commits into from Aug 10, 2022
Merged

expose Utils.hs as library #40

merged 3 commits into from Aug 10, 2022

Conversation

thma
Copy link

@thma thma commented Jul 29, 2022

In a project of mine I wrote a dependency validation which builds upon your Utils.hs.
As Utils is not part of the exposed-modules declaration in graphmod.cabal I had to include a verbatim copy of Utils.hs to my code base.

With this pull request Util is made part of the exposed-modules declaration.
This will allow to also access Utils.hs when adding graphmod as a library dependency.

In a second commit I made Qualifier and Import instances of Eq by changing their deriving clauses.
This will allow testing for equally in user code.

thanks for your very useful tool!

@yav
Copy link
Owner

yav commented Jul 31, 2022

Hi,
thanks for the contribution! I don't mind exposing Utils, but I wonder if we should move it to Graphmod.Utils to avoid name clashes for anyone else who might be using graphmod as a library. Would you mind doing that change?

@thma
Copy link
Author

thma commented Jul 31, 2022

I thought about that name clash issue as well, as quite a few libraries have some kind of 'Utils' somewhere...
Yes, I'll extend my PR by renaming Utils to Graphmod.Utils

@thma
Copy link
Author

thma commented Jul 31, 2022

Done !

@thma
Copy link
Author

thma commented Aug 1, 2022

Hi again,

For the sake of consistency, wouldn'd it be better to also move Trie and CabalSupport to the Graphmod folder?

If you agree, I'll add that to the PR.

best regards,
Thomas

@yav yav merged commit cc44d12 into yav:master Aug 10, 2022
@yav
Copy link
Owner

yav commented Aug 10, 2022

Thanks! I just merged the PR and moved the other modules as you suggested. Does it matter for you if I put a new version on Hackage, or is GitHub sufficient?

@thma
Copy link
Author

thma commented Aug 13, 2022

Having a new version on Hackage would be cool (to allow even simpler integration via stack/cabal). But it's not urgent.
BTW: here is the blog post on graphmod and my addon dependency checker:
https://thma.github.io/posts/2022-08-07-dependency-validation-of-haskell-applications.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants