config var improvements

[duralakun]

I am still working on this and want to add more stuff.

What is working already is a new command called "print_cfg"
You can type it in rcon console (F2) to get information about config vars.

For example "print_cfg hero" outputs this for me:

inf_hero_limit 10
inf_enable_hero 1
inf_hero_flag_indicator 0

"print_cfg map" outputs this for me:

sv_maprotation infc_skull infc_warehouse infc_damascus infc_hardcorepit
sv_rounds_per_map 8
sv_mapupdaterate 5
sv_map infc_hardcorepit
inf_map_window 15
inf_maprotation_random 1
inf_min_rounds_map_vote 0
inf_min_player_percent_map_vote 100
inf_min_player_number_map_vote 3
sv_maprotation infc_skull infc_warehouse infc_damascus infc_hardcorepit
sv_rounds_per_map 8
sv_mapupdaterate 5

[duralakun]

Added new command "print_cmd", it works similar to "print_cfg", Examples:

print_cmd map

Printing all commands containing 'map' :
change_map ?"text..." -> Change map
skip_map -> Change map to the next in the rotation

print_cmd ban

Printing all commands containing 'ban' :
ban "clientid" ?minutes ?"reason" -> Ban player with ip/client id for x minutes for any reason
ban_range "text" -> Ban ip range for x minutes for any reason
bans -> Show banlist
bans_save "text" -> Save banlist in a file
unban "text" -> Unban ip/banlist entry
unban_all -> Unban all entries
unban_range "text" -> Unban ip range

[duralakun]

About the last commit:

I renamed printcfg and printcmd to print_cfg and print_cmd, also improved related code to it a bit.

Created new commands: set_cfg_for_nextround_begin, set_cfg_for_nextround_end, print_round_cfg
You can now type set_cfg_for_nextround_begin into the console in order to let the server remember upcoming config variable changes, then type set_cfg_for_nextround_end if you dont want to add more vars. These vars will be reset at the start of the next round.
While these vars are not reset you can see them with print_round_cfg.

This gives the option to create fun rounds with config files.
To demonstrate it i added another file called fr_boooper.cfg
https://github.com/yavl/teeworlds-infclassR/pull/103/files#diff-7df5e64bdd184dc65fdb6a4756b7cc74R1
the name fr_boooper means FunRound_BoomerLooper
to start this funround type "exec fr_boooper.cfg" into the rcon console.
i added comments inside the cfg file to explain it.

[duralakun]

I want to add more features related to this. But for now i am finished with it and would like to test and if it works, merge it.

[duralakun]

breton asked me in game why this define stuff inside the function, please take a look at here:
https://github.com/yavl/teeworlds-infclassR/blob/master/src/engine/shared/console.cpp#L727
i did it like it is done here

The way it works is that you define 2 functions MACRO_CONFIG_INT and MACRO_CONFIG_STR and then you include the config files, the included files will than call your defined functions, this way you can get all the information about the config variables

Here the MACROs will be called: https://github.com/yavl/teeworlds-infclassR/blob/master/src/engine/shared/config_variables.h

You can also see a lot of defines inside functions here: https://github.com/yavl/teeworlds-infclassR/blob/master/src/engine/shared/config.cpp#L53

[teoman002]

Closed #96

[bretonium]

why does this line need to be here?

[teoman002]

It's for debug purposes. I also uncomment these lines, because they can be useful for debugging.
We could introduce a verbose flag set during the compile-process, which would activate this line.

[bretonium]

why this change on commented out code? Changes like this make it harder to review the changes. The reviewer, instead of reviewing actual change, has to waste attention on this

[bretonium]

could you please just remove unused code at all?