Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getters and setters #22

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add getters and setters #22

wants to merge 3 commits into from

Conversation

bendikv
Copy link

@bendikv bendikv commented May 6, 2016

No description provided.

@yavski
Copy link
Owner

yavski commented Oct 16, 2016

Sorry for taking ages to respond - why do you need those changes? Your changes go against the open / closed principle, perhaps there is another way to achieve what you're after.

@pedantix
Copy link

@yavski I can think of a good reason for some of these, my designer wishes to change colors of menu items depending on which activity the FAB is in, this of course could be achieved with five different menu layouts and five different activity layouts but that seems like a lot of bloat and very difficult to change. Being able to programmatically set colors would be super nice, or at the very least affect the states such as enabled vs disabled of individual menu items so as to change colors via selectors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants