Added custom animation support for FAB button #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed add-animation to animated vectors (better scalable) and also allows for custom animated drawables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for custom animations of the FAB by passing a normal statelist and having two Animatables as states. The Dialer will recognize that the drawable is animatable and will run the animation.
In the default implementation this allows to replace the 10 PNGs with one vector drawable and a bunch of animations which is smaller, neater and better scalable.
Furthermore I prefixed all IDs in the resource files since an ID mismatch would occur if you would call your SpeedDialer "fab" and you would get casting errors.