Update NetworkACL by replacement #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NetworkAcl that matches our local ruleset
Jc2k
force-pushed
the
update_by_replacement
branch
from
f556a73
to
4b05b04
Compare
Jc2k
force-pushed
the
update_by_replacement
branch
from
a8e4c62
to
62dbe44
Compare
Jc2k
force-pushed
the
update_by_replacement
branch
from
6f8a8f7
to
c0dd77f
Compare
Jc2k
force-pushed
the
update_by_replacement
branch
from
fae63e0
to
63c8fe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more efficient (in terms of API calls) and safe (in terms of database transaction like atomic switching) to create a network acl and update subnets to use it rather than modifying an existing one in place. This PR switched Network ACL to use this style of deployment, and includes serializer/diffing improvements to better handle the structure of the NetworkACL Rule type.
Todo:
vpc.add_network_acl(port=23)vpc.add_network_acl(port_start=23, port_end=23)