Support enum type #11

KeitaMoromizato · 2017-10-18T00:37:38Z

Parse enum properties.

yaml

status:
  type: string
  enum:
    - active
    - inactive

generated flow file.

type Hoge = {
  status: "active" | "inactive"
}

yayoc · 2017-10-23T14:48:37Z

src/index.js

@@ -34,6 +34,11 @@ const typeFor = (property: any): string => {
    }
    return `Array<${typeMapping[property.items.type]}>`;
  }
+  else if (property.type === 'string' && 'enum' in property) {
+    return property.enum.reduce((acc: string, e: string) => {


Thanks for contributing.
As a minor staff, probably slice(1) seems a bit tricky.
You would be able to replace with below statement.

return property.enum.map(a => `'${a}'`).join(" | ");

Thank you.

Thanks for comment.

I fixed this. Please review again.

yayoc · 2017-10-26T02:04:01Z

Thank you for updating. will merge this PR.

KeitaMoromizato added 2 commits October 17, 2017 23:15

parse enum

26e8f44

pass enum test

a26dbe7

yayoc reviewed Oct 23, 2017

View reviewed changes

Simplify generating enum statement.

195fb73

yayoc merged commit 71c344e into yayoc:master Oct 26, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support enum type #11

Support enum type #11

KeitaMoromizato commented Oct 18, 2017

yayoc Oct 23, 2017

KeitaMoromizato Oct 24, 2017

yayoc commented Oct 26, 2017

Support enum type #11

Support enum type #11

Conversation

KeitaMoromizato commented Oct 18, 2017

yayoc Oct 23, 2017

Choose a reason for hiding this comment

KeitaMoromizato Oct 24, 2017

Choose a reason for hiding this comment

yayoc commented Oct 26, 2017