Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Not Perform Snapshot Cleanup #103

Open
MrHamel opened this issue Dec 17, 2023 · 4 comments
Open

Does Not Perform Snapshot Cleanup #103

MrHamel opened this issue Dec 17, 2023 · 4 comments

Comments

@MrHamel
Copy link

MrHamel commented Dec 17, 2023

On a Proxmox install of mine, pyznap is not removing the old snapshots, even though clean = yes is specified in the config file.

Below is what I mean by very old snapshots. I would like to only keep the snapshots as mentioned in the schedule.

storage@pyznap_2023-02-03_10:57:31_monthly                       0B      -       30K  -
storage@pyznap_2023-02-03_10:57:31_weekly                        0B      -       30K  -
storage@pyznap_2023-02-03_10:57:31_daily                         0B      -       30K  -
storage@pyznap_2023-02-04_00:00:01_daily                         0B      -       30K  -
storage@pyznap_2023-02-05_00:00:01_daily                         0B      -       30K  -
storage@pyznap_2023-02-06_00:00:01_weekly                        0B      -       30K  -
storage@pyznap_2023-02-06_00:00:01_daily                         0B      -       30K  -
storage@pyznap_2023-02-07_00:00:01_daily                         0B      -       30K  -
storage@pyznap_2023-02-08_00:00:01_daily                         0B      -       30K  -
storage@pyznap_2023-02-09_00:00:01_daily                         0B      -       30K  -
storage@pyznap_2023-02-10_00:00:01_daily                         0B      -       30K  -
storage@pyznap_2023-02-11_00:00:02_daily                         0B      -       30K  -
storage@pyznap_2023-02-12_00:00:01_daily                         0B      -       30K  -
storage@pyznap_2023-02-13_00:00:01_weekly                        0B      -       30K  -
@aaltonenp
Copy link

I had the same problem, until I realized I was only pulling with 'send' and not doing the cleanup with 'snap --clean'. They have to be done separately. At least that was my problem when I did a new install after a long time.

@MrHamel
Copy link
Author

MrHamel commented May 31, 2024

This does not resolve the issue unfortunately. I got a 200GB container eating 2TB because it hasn't cleaned anything up in the last 9 months.

@MrHamel
Copy link
Author

MrHamel commented May 31, 2024

To clarify, I want it to cleanup the snapshots on the local pool before sending.

@MrHamel
Copy link
Author

MrHamel commented May 31, 2024

It just dawned on me what the issue was. In the config file, if comments proceed the parameters value, it does not get parsed correctly. These config file parsing bugs create some real gotchas and need to be resolved ASAP.

Valid:

clean = yes

Invalid:

clean = yes # This is a random comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants