Completion menu redisplayed after confirming completion with C-y

[radioneko]

Steps to reproduce:

• select completion from menu with tab/s-tab
• confirm it by pressing C-y

After this completion menu popping again showing matches for word that was just inserted (including this word itself, so menu always has at least one item). If completion is aborted with C-e, no additional menus shown.

[radioneko]

It seems that second menu is semantic completion (ie just like C-Space was pressed immediately after C-y)

[vheon]

I don't understand the need to confirm the completion using <C-y>. That is not the way YCM is designed to work. When you select the completion with <Tab> you don't need to do anything more that that. I think I'm going to close this issue since is basically a duplicate of #1272 and that is been closed as well by @Valloric.

[radioneko]

Sometimes I really need to insert some alignment with <Tab> right after completed name. Currently there're three workarounds which aren't convenient:

• double <C-y>
• <Space> followed by <Tab>
• don't use tab for menu navigation

[vheon]

Ok, I reopened this and we'll wait and see what @Valloric thinks about this.

[Liangzhi233]

Here is a situation where I need <c-y>. I use <tab> both for cycling through candidates in ycm and placeholders in ultisnips. But after ycm giving me some candidates, I cannot jump to next placeholder without closing the popup menu.

By the way, #1272 works perfect, and introduce little complexity in my opinion

[radioneko]

I have some luck in fixing it but this requres patching vim.
This double menu appears only because heuristics is used to detect line change: s:BufferTextChangedSinceLastMoveInInsertMode verifying current line length to detect if there was a change made in insert mode. When you accept completion with <C-y> line length suddenly changes (I suspect CursorHoldI is not called when pum menu is visible but haven't checked this).
My idea of fixing is just to forbid completion in s:AllowedToCompleteInCurrentFile if last key event caused accepting item from complete menu.
So I added variable to vim which is set to TRUE when <C-y> accepted pum menu item and reset to FALSE at before next key is read from edit() function. Then there's a VimL function for quering his flag value. And finally I've modified s:AllowedToCompleteInCurrentFile:

function! s:AllowedToCompleteInCurrentFile()
...
  " Make sure we don't double showing completion menu
  if exists( '*pumjustaccepted' ) && pumjustaccepted()
    return 0
  endif

  return whitelist_allows && blacklist_allows
endfunction

Maybe someone could point out better way for resolving this issue that could be accepted by vim upstream?

[vheon]

I suspect CursorHoldI is not called when pum menu is visible but haven't checked this

That is correct.

Personally I don't think that patching vim this way is the right thing to do.

EDIT: There's something similar to the pumjustaccepted() function but is an autocmd (:h CompleteDone) maybe we could thing something about that but I don't know if it will be a clean patch to YCM.

[Liangzhi233]

@radioneko is right, the second popup menu shows because first <c-y> changes the input text. Why not disable showing the candidate if it's exactly same as the word you just input? By this method, the second menu will not show, because all its candidates are same as your input. This solution only needs one python expression
results = filter(lambda a:a.get('abbr', a['word'])!=baseText or a.get('menu'), results)
added in autoload/youcompleteme.vim

[vheon]

This solution only needs one python expression
results = filter(lambda a:a.get('abbr', a['word'])!=baseText or a.get('menu'), results)
added in autoload/youcompleteme.vim

@LiangZhi1027 The fact that is only one line doesn't mean that is a simple and clean way to fix it. That line needs to be maintained by someone who is not you. In the meantime you could always use <C-y> to select the candidate and cancel the second popup with <C-e>.

[radioneko]

@LiangZhi1027: imagine you have following candidates: ['free', 'free_foo', 'free_bar']. You type fr and want to complete to free. You hit <C-y> on free, then second menu appears suggesting free_foo and free_bar.
@vheon agreed. The only thing that confuses me is that first completion menu in not semantic (ie functions not showing their prototypes), and second menu that pops is semantic (it shows function prototypes and has much more indentifiers for completion).

[Liangzhi233]

@radioneko Thanks for this example. I didn't consider it. So my solution isn't right :(

[radioneko]

I have patches for (g)vim and youcompleteme, so if anyone wants try it:
ycm patch (doesn't produce errors with unpatched vim) https://github.com/radioneko/gentoo-overlay/blob/master/app-editors/vim/files/vim-ycm-hack.patch
vim/gvim patch: https://github.com/radioneko/gentoo-overlay/blob/master/app-vim/youcompleteme/files/ycm-double-pum.patch

[vheon]

@radioneko @Liangzhi233 Actually I think I just solve this without patching vim. The problem is that it require to call the s:UpdateCursorMoved() function which is not callable from outside. Anyway I just added this inside autoload/youcompleteme.vim and all seems to work:

function! CtrlY()
  if pumvisible()
    call s:UpdateCursorMoved()
  endif
  return "\<C-y>"
endfunction
inoremap <expr> <C-y> CtrlY()

[blueyed]

I had a similar problem, where <c-x><c-u> (manually calling the completion) does not work after <c-w> (which closes the completion menu, but does not move the cursor):

In youcompleteme#EnableCursorMovedAutocommands(), add this:

autocmd CompleteDone * let s:old_cursor_position = []

See blueyed@3d035e9

I hope it works for your case - I could not reproduce the issue.

[blueyed]

Update: the method from my previous comment did not work properly. I have changed it to call s:UpdateCursorMoved explicitly from the *Complete functions.

[przepompownia]

This issue is still relevant. I tested it with disabled another plugins to eliminate another potential causes of displaying menu:
LC_MESSAGES=C vim -i NONE -u ~/.vim/vimrc-test-with-sys-rtp /tmp/ssh_config
where

 $ cat ~/.vim/vimrc-test-with-sys-rtp
" vim: filetype=vim
set nocp
filetype plugin indent on
syntax on
set mouse=a
set runtimepath=/usr/share/vim/vimfiles,/usr/share/vim/vim74,/usr/share/vim/vimfiles/after
set runtimepath+=~/.vim/bundle/YouCompleteMe

ssh_config is detected as sshconfig filetype and contains only two words: Host and Hostname which become menu items after typing Ho in another place. To close menu (without typing character such as whole string does not match to any item) I must press Ctrl-y twice. It does not depend on whether I cycle through items using TAB or Ctrl-N.

I also tried

inoremap <expr> <CR> pumvisible() ? "\<C-Y>" : "\<CR>"

and I must confirm using Enter twice too.

[alvminvm]

@przepompownia
try this:
inoremap <expr> <CR> pumvisible() ? "\<C-Y>\<ESC>a" : "\<CR>"