-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ycm completes html error #2058
Comments
😕 guys thoughts? |
The issue is not specific to a templated html. For example: <div>test.test</div>
We could exclude the dot character but according to HTML specs, dot is a valid character in tag names and attribute names/values even if I am not aware of any tag and attribute names containing a dot and dots in attribute values are rarely (never?) used. |
ops, sorry |
Could YCM support vim's iskeyword as identifier? |
Probably but YCM currently uses regexes to extract identifiers which are much more powerful than Vim |
Like @micbou said, supporting |
These are commonly used for HTML templating; see Handlebars, Angular etc. Fixes ycm-core/YouCompleteMe#2058
thanks! |
These are commonly used for HTML templating; see Handlebars, Angular etc. Fixes ycm-core/YouCompleteMe#2058
Ignoring HTML template chars `{` and `}` These are commonly used for HTML templating; see Handlebars, Angular etc. Fixes ycm-core/YouCompleteMe#2058 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/436) <!-- Reviewable:end -->
Why is YCM using regex to parse HTML? I thought we were past this haha |
In html, YCM treated dot as part of identifier.
vim -version
vim html keyword config:
YCM config:
The text was updated successfully, but these errors were encountered: