Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Remove s:GetCompletions function #2513

Merged
merged 1 commit into from Jan 26, 2017

Conversation

micbou
Copy link
Collaborator

@micbou micbou commented Jan 24, 2017

Small refactoring.


This change is Reviewable

@codecov-io
Copy link

codecov-io commented Jan 25, 2017

Current coverage is 85.20% (diff: 100%)

Merging #2513 into master will not change coverage

@@             master      #2513   diff @@
==========================================
  Files            19         19          
  Lines          1980       1980          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1687       1687          
  Misses          293        293          
  Partials          0          0          

Powered by Codecov. Last update 60f3db1...5ece7ae

@vheon
Copy link
Contributor

vheon commented Jan 25, 2017

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@Valloric
Copy link
Member

Thanks!

@homu r=vheon


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@homu
Copy link
Contributor

homu commented Jan 26, 2017

📌 Commit 5ece7ae has been approved by vheon

@homu
Copy link
Contributor

homu commented Jan 26, 2017

⚡ Test exempted - status

@homu homu merged commit 5ece7ae into ycm-core:master Jan 26, 2017
homu added a commit that referenced this pull request Jan 26, 2017
[READY] Remove s:GetCompletions function

Small refactoring.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2513)
<!-- Reviewable:end -->
@micbou micbou deleted the get-completions branch January 26, 2017 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants