[READY] Do not disable omnifunc when filetype completion is disabled

[micbou]

Prior to PR #2657, it was possible to trigger Vim's omnifunc with <C-Space> even if semantic completion was disabled for the current filetype through the g:ycm_filetype_specific_completion_to_disable option. It worked because <C-Space> was mapped to <C-X><C-O><C-P>, which are the keys to trigger the omnifunc. PR #2657 changed that by making <C-Space> directly call the SendCompletionRequest function with force_semantic sets to True. This change was necessary to get fuzzy matching with the omnifunc (see issue #961) but broke the <C-Space> behavior when filetype completion is disabled. This PR restores that behavior.

Fixes #2950.

---

This change is 

[codecov-io]

Codecov Report

Merging #2978 into master will increase coverage by 0.73%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2978      +/-   ##
==========================================
+ Coverage    92.6%   93.34%   +0.73%     
==========================================
  Files          21       21              
  Lines        2070     2359     +289     
==========================================
+ Hits         1917     2202     +285     
- Misses        153      157       +4

[bstaletic]

---

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[puremourning]

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

python/ycm/omni_completer.py, line 67 at r1 (raw file):

  def _CurrentFiletypeCompletionDisabled( self ):

This looks like the same logic from youcompleteme.py ? Can we avoid duplicating it ?

---

Comments from Reviewable

[micbou]

Reviewed 1 of 3 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

python/ycm/omni_completer.py, line 67 at r1 (raw file):

Previously, puremourning (Ben Jackson) wrote…

This looks like the same logic from youcompleteme.py ? Can we avoid duplicating it ?

Added a new function CurrentFiletypesEnabled in vimsupport.

---

Comments from Reviewable

[puremourning]

@zzbot r+

---

Reviewed 1 of 3 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

Comments from Reviewable

[zzbot]

📌 Commit e96ef7c has been approved by puremourning

[zzbot]

⌛ Testing commit e96ef7c with merge 7d72519...

[zzbot]

☀️ Test successful - status-appveyor, status-travis
Approved by: puremourning
Pushing 7d72519 to master...