Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock closed issues older than 60 days #3884

Merged
merged 1 commit into from
May 3, 2021

Conversation

puremourning
Copy link
Member

@puremourning puremourning commented May 3, 2021

This locks issues which are:

  • issues, not PRs
  • closed
  • not updated in last 60 days.

Runs once a day at around midnight (in some timezone, shrug). Can be run manually.

Code for the action:
https://github.com/dessant/lock-threads/blob/master/src/index.js

Settings for the action:
https://github.com/dessant/lock-threads#inputs

Things we might want to do:

  • also lock closed PRs ?
  • add a custom message like "Locking issue as it is closed and has not been updated for 60 days"

This change is Reviewable

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #3884 (37eaee7) into master (ee7f9b6) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3884      +/-   ##
==========================================
+ Coverage   91.52%   91.66%   +0.13%     
==========================================
  Files          27       27              
  Lines        3682     3682              
==========================================
+ Hits         3370     3375       +5     
+ Misses        312      307       -5     

Copy link
Collaborator

@bstaletic bstaletic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also lock closed PRs ?

I don't think so. Leaving PRs unlocked doesn't attract as much necrobumping and it's nice in case of "hey, git bisect points to this PR".

add a custom message like "Locking issue as it is closed and has not been updated for 60 days"

I guess we've decided not to.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @puremourning)

@puremourning puremourning merged commit 11a8ca3 into ycm-core:master May 3, 2021
@ulidtko
Copy link

ulidtko commented May 3, 2021

Why, what in the github is wrong with necrobumping... StackOverflow even rewards it! 😁

It's almost like you're trying to discourage folks from using search by making this change. Gone are the days when checking search before asking was good netiquette?

I'm sure you have your reasons, totally respecting those and am here not to persuade — just be aware of crap like here probot/stale#312. Of course, I hope dessant/lock-threads will be much different.

Appreciated that at least PRs are left alone.

@puremourning puremourning deleted the lock_old_issues branch May 4, 2021 06:39
@puremourning
Copy link
Member Author

It's almost like you're trying to discourage folks from using search by making this change. Gone are the days when checking search before asking was good netiquette?

quite the opposite. CONTRIBUTING.md is clear enough about this.

Posting on very old, closed issues is usually pointless and most often does not add useful data. It’s better to raise a new isssue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants