WIP: use rogpeppe/godef instead of Manishearth/godef

[timfeirg]

required by ycm-core/YouCompleteMe#2991

---

This change is 

[bstaletic]

The builds failed because you didn't unregister the old submodule before registering a new one, so git is still looking for the commit from the Manisheart's fork, but now it is looking for it in the upstream repo.

Here's how submodules are changed:

• https://stackoverflow.com/questions/1260748/how-do-i-remove-a-submodule/1260982#1260982
• git submodule add <new remote> third_party/godef
• Commit and push

[bstaletic]

The latest commit should do the job. Let's see if the tests pass.

[timfeirg]

Building godef failed with dependency issues, see https://travis-ci.org/Valloric/ycmd/jobs/369066405.

I've added godep into build.py to see if it'll work.

[bstaletic]

There is a ycmd_compat branch on Manisheart's fork and here's what it changed from the defaults:
rogpeppe/godef@master...Manishearth:ycmd_compat

[micbou]

This fails because the forked godef has custom changes to make it work.

@Manishearth Could you update your godef fork with the latest changes and prepare a PR?

---

Reviewed 2 of 5 files at r1, 1 of 1 files at r2.
Review status: 3 of 6 files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[timfeirg]

Since godep is an outdated tool, it could be a better idea to migrate from godep to dep for the godef project.
Or just exclude godef from ycm at all, that'd really unload the mess we're having in this PR, and just let user install godef on their own.

[bstaletic]

I have updated and rebased @Manishearth's changes in my godef fork. The ycmd branch with the updated godef is here.

@timfeirg Can you try my ycmd branch and confirm it fixes the jump to vendor bug?

[Manishearth]

I'll update my fork We can't use the original since it needs gopath

…

On Fri, Apr 20, 2018, 7:10 AM Boris Staletic ***@***.***> wrote: I have updated and rebased @Manishearth <https://github.com/Manishearth>'s changes in my godef fork. The ycmd branch with the updated godef is here <https://github.com/bstaletic/ycmd/tree/godef_update>. @timfeirg <https://github.com/timfeirg> Can you try my ycmd branch and confirm it fixes the jump to vendor bug? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1005 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABivSJewNC9tcwAQVHzDLnVp-NFaqLXYks5tqexOgaJpZM4TdKeN> .

[Manishearth]

Bumping the submodule pointer to https://github.com/Manishearth/godef/tree/ycmd_compat (c3b70c6) should be enough. I don't want to break older versions of YCMD so I'll keep that old branch around as ycmd_old and rename the new one.

[bstaletic]

Thanks @Manishearth! I've opened #1006 to update ycmd's submodule.

[micbou]

Superseded by PR #1006.