Update the server with current file state after a restart #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstaletic
force-pushed
the
update-files-after-server-reset
branch
from
dff1406
to
b3f8424
Compare
|
Should be ready now. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1730 +/- ##
=======================================
Coverage 95.44% 95.44%
=======================================
Files 83 83
Lines 8167 8168 +1
Branches 163 163
=======================================
+ Hits 7795 7796 +1
Misses 322 322
Partials 50 50 |
puremourning
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)
bstaletic
force-pushed
the
update-files-after-server-reset
branch
from
b3f8424
to
84ee7c3
Compare
Previously, ycmd would not update the LSP server with the current file state after RestartServer subcommand had been issued. This causes some stale diagnostics to linger.
|
Thanks for sending a PR! |
bstaletic
added a commit
to ycm-core/YouCompleteMe
that referenced
this pull request
Feb 18, 2024
Changes since the last update: ycm-core/ycmd#1728 YcmShowDetailedDiagnostic should now match what is echoed on the command line. ycm-core/ycmd#1731 Add support for `workspace/didChangeWorkspaceFolders` LSP notification. ycm-core/ycmd#1730 LSP servers are now updated with latest server state afer reset ycm-core/ycmd#1727 Update JDT to version 1.31.0 ycm-core/ycmd#1726 C# symbol search filtering fix ycm-core/ycmd#1724 C# GoToDocumentOutline consistency patch ycm-core/ycmd#1723 Implement GoToDocumentOutline in C# ycm-core/ycmd#1716 Display tsserver tags in detailed info and GetDoc `workspace/didChangeWorkspaceFolders` seems to be working fine for java, rust and go, but should be considered experimental. Definitely more field experience is needed. What it should do is allow LSP servers to understand multiple projects in the same vim instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ycmd would not update the LSP server with the current file state after RestartServer subcommand had been issued. This causes some stale diagnostics to linger.
This change is