Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Storing path to Python used in build.py #466

Merged
merged 1 commit into from
Apr 27, 2016
Merged

[READY] Storing path to Python used in build.py #466

merged 1 commit into from
Apr 27, 2016

Conversation

Valloric
Copy link
Member

@Valloric Valloric commented Apr 26, 2016

We'll use this in YCM to ensure we start ycmd with the same version of
Python that was used for building the C++ libraries loaded into ycmd.

Related to ycm-core/YouCompleteMe#2136


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.723% when pulling c1cf807 on ubuntu-fix into a3c41b4 on master.

Valloric added a commit to ycm-core/YouCompleteMe that referenced this pull request Apr 26, 2016
Note: depends on ycm-core/ycmd#466 being merged and the ycmd submodule
ref then being updated.

Fixes #2136
Valloric added a commit to ycm-core/YouCompleteMe that referenced this pull request Apr 26, 2016
Note: depends on ycm-core/ycmd#466 being merged and the ycmd submodule
ref then being updated.

Fixes #2136
Valloric added a commit to ycm-core/YouCompleteMe that referenced this pull request Apr 26, 2016
Note: depends on ycm-core/ycmd#466 being merged and the ycmd submodule
ref then being updated.

Fixes #2136
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.723% when pulling 0eb4e51 on ubuntu-fix into a3c41b4 on master.

@micbou
Copy link
Collaborator

micbou commented Apr 26, 2016

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


build.py, line 43 [r2] (raw file):
This variable is already defined above.


Comments from Reviewable

We'll use this in YCM to ensure we start ycmd with the same version of
Python that was used for building the C++ libraries loaded into ycmd.
@Valloric
Copy link
Member Author

Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.


build.py, line 43 [r2] (raw file):
Ha, good catch. Fixed.


Comments from Reviewable

@Valloric Valloric changed the title Storing path to Python used in build.py [READY] Storing path to Python used in build.py Apr 26, 2016
Valloric added a commit to ycm-core/YouCompleteMe that referenced this pull request Apr 26, 2016
Note: depends on ycm-core/ycmd#466 being merged and the ycmd submodule
ref then being updated.

Fixes #2136
@micbou
Copy link
Collaborator

micbou commented Apr 27, 2016

:lgtm:


Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.723% when pulling 5390348 on ubuntu-fix into a3c41b4 on master.

@Valloric
Copy link
Member Author

@puremourning @vheon review?

@puremourning
Copy link
Member

Only optional thought is maybe prefix the filename with . to make it hidden on UNIX. But meh not a biggie.

:lgtm: fire when ready.


Reviewed 1 of 2 files at r1, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@vheon
Copy link
Contributor

vheon commented Apr 27, 2016

@puremourning @vheon review?

I actually tried to do this today from another computer but had a problem with reviewable (and still have) :(

:lgtm: @homu r=micbou

@homu
Copy link
Contributor

homu commented Apr 27, 2016

📌 Commit 5390348 has been approved by micbou

1 similar comment
@homu
Copy link
Contributor

homu commented Apr 27, 2016

📌 Commit 5390348 has been approved by micbou

@homu
Copy link
Contributor

homu commented Apr 27, 2016

💡 This pull request was already approved, no need to approve it again.

@homu
Copy link
Contributor

homu commented Apr 27, 2016

⚡ Test exempted - status

@homu homu merged commit 5390348 into master Apr 27, 2016
homu added a commit that referenced this pull request Apr 27, 2016
[READY] Storing path to Python used in build.py

We'll use this in YCM to ensure we start ycmd with the same version of
Python that was used for building the C++ libraries loaded into ycmd.

Related to ycm-core/YouCompleteMe#2136

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/466)
<!-- Reviewable:end -->
Valloric added a commit to ycm-core/YouCompleteMe that referenced this pull request Apr 28, 2016
Note: depends on ycm-core/ycmd#466 being merged and the ycmd submodule
ref then being updated.

Fixes #2136
homu added a commit to ycm-core/YouCompleteMe that referenced this pull request Apr 28, 2016
[READY] Starting ycmd with Python used to build it

Note: depends on ycm-core/ycmd#466 being merged and the ycmd submodule
ref then being updated.

Fixes #2136

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2140)
<!-- Reviewable:end -->
@Valloric Valloric deleted the ubuntu-fix branch May 13, 2017 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants