-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] Storing path to Python used in build.py #466
Conversation
Note: depends on ycm-core/ycmd#466 being merged and the ycmd submodule ref then being updated. Fixes #2136
Note: depends on ycm-core/ycmd#466 being merged and the ycmd submodule ref then being updated. Fixes #2136
Note: depends on ycm-core/ycmd#466 being merged and the ycmd submodule ref then being updated. Fixes #2136
Reviewed 1 of 2 files at r1, 1 of 1 files at r2. build.py, line 43 [r2] (raw file): Comments from Reviewable |
We'll use this in YCM to ensure we start ycmd with the same version of Python that was used for building the C++ libraries loaded into ycmd.
Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion. build.py, line 43 [r2] (raw file): Comments from Reviewable |
Note: depends on ycm-core/ycmd#466 being merged and the ycmd submodule ref then being updated. Fixes #2136
Reviewed 1 of 1 files at r3. Comments from Reviewable |
@puremourning @vheon review? |
Only optional thought is maybe prefix the filename with Reviewed 1 of 2 files at r1, 1 of 1 files at r3. Comments from Reviewable |
I actually tried to do this today from another computer but had a problem with reviewable (and still have) :(
|
📌 Commit 5390348 has been approved by |
1 similar comment
📌 Commit 5390348 has been approved by |
💡 This pull request was already approved, no need to approve it again. |
⚡ Test exempted - status |
[READY] Storing path to Python used in build.py We'll use this in YCM to ensure we start ycmd with the same version of Python that was used for building the C++ libraries loaded into ycmd. Related to ycm-core/YouCompleteMe#2136 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/466) <!-- Reviewable:end -->
Note: depends on ycm-core/ycmd#466 being merged and the ycmd submodule ref then being updated. Fixes #2136
[READY] Starting ycmd with Python used to build it Note: depends on ycm-core/ycmd#466 being merged and the ycmd submodule ref then being updated. Fixes #2136 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2140) <!-- Reviewable:end -->
We'll use this in YCM to ensure we start ycmd with the same version of
Python that was used for building the C++ libraries loaded into ycmd.
Related to ycm-core/YouCompleteMe#2136
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)