[READY] Write python used during build before installing completers #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
Yep. Cheers! Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
📌 Commit ff75920 has been approved by |
zzbot
added a commit
that referenced
this pull request
Aug 3, 2017
…pleters, r=vheon [READY] Write python used during build before installing completers If ycmd compilation is successful but installing a completer fails, we don't create the `PYTHON_USED_DURING_BUILDING` file. This can be an issue if the user gives up on the completer installation and the client uses the Python from this file to start ycmd (like YCM does). This could explain issue ycm-core/YouCompleteMe#2729. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/808) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
Hmmm. Auto cancellation on travis? Wtf? @zzbot retry Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
zzbot
added a commit
that referenced
this pull request
Aug 3, 2017
…pleters, r=vheon [READY] Write python used during build before installing completers If ycmd compilation is successful but installing a completer fails, we don't create the `PYTHON_USED_DURING_BUILDING` file. This can be an issue if the user gives up on the completer installation and the client uses the Python from this file to start ycmd (like YCM does). This could explain issue ycm-core/YouCompleteMe#2729. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/808) <!-- Reviewable:end -->
Wouldn't be the first time it happened. Prevented us from merging one PR for a while recently. |
|
💔 Test failed - status-travis |
Codecov Report
@@ Coverage Diff @@
## master #808 +/- ##
=======================================
Coverage 94.75% 94.75%
=======================================
Files 79 79
Lines 5317 5317
Branches 170 170
=======================================
Hits 5038 5038
Misses 232 232
Partials 47 47 |
|
I've disabled auto cancellation of branch builds on Travis. @zzbot shouldn't cancel its own builds anymore. Still, I think we should do something about it. Maybe report the issue on the homu repository. Ping @Valloric. @zzbot retry Reviewed 1 of 1 files at r1. Comments from Reviewable |
zzbot
added a commit
that referenced
this pull request
Aug 3, 2017
…pleters, r=vheon [READY] Write python used during build before installing completers If ycmd compilation is successful but installing a completer fails, we don't create the `PYTHON_USED_DURING_BUILDING` file. This can be an issue if the user gives up on the completer installation and the client uses the Python from this file to start ycmd (like YCM does). This could explain issue ycm-core/YouCompleteMe#2729. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/808) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
☀️ Test successful - status-travis |
zzbot
added a commit
to ycm-core/YouCompleteMe
that referenced
this pull request
Sep 10, 2017
[READY] Update ycmd This new version of ycmd includes the following changes: - PR ycm-core/ycmd#795: add option to make relative paths in flags from extra conf absolute; - PR ycm-core/ycmd#802: fix compilation on Haiku; - PR ycm-core/ycmd#804: add libclang detection on FreeBSD; - PR ycm-core/ycmd#808: write python used during build before installing completers; - PR ycm-core/ycmd#810: support unknown languages from tags; - PR ycm-core/ycmd#811: update Universal Ctags languages list; - PR ycm-core/ycmd#814: resolve symlinks in extra conf glob patterns; - PR ycm-core/ycmd#815: update JediHTTP; - PR ycm-core/ycmd#816: update Boost to 1.65.0; - PR ycm-core/ycmd#819: filter and sort candidates when query is empty; - PR ycm-core/ycmd#820: improve LLVM root path search for prebuilt binaries; - PR ycm-core/ycmd#822: inline critical utility functions; - PR ycm-core/ycmd#824: do not sort header paths in filename completer; - PR ycm-core/ycmd#825: implement partial sorting; - PR ycm-core/ycmd#830: add max_num_candidates option; - PR ycm-core/ycmd#831: fix multiline comments and strings issues; - PR ycm-core/ycmd#832: update Clang to 5.0.0. The `g:ycm_max_num_candidates` and `g:ycm_max_num_identifier_candidates` options are added to the documentation. The link to ycmd extra conf is updated. Fixes #2562. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2768) <!-- Reviewable:end -->
zzbot
added a commit
to ycm-core/YouCompleteMe
that referenced
this pull request
Sep 10, 2017
[READY] Update ycmd This new version of ycmd includes the following changes: - PR ycm-core/ycmd#795: add option to make relative paths in flags from extra conf absolute; - PR ycm-core/ycmd#802: fix compilation on Haiku; - PR ycm-core/ycmd#804: add libclang detection on FreeBSD; - PR ycm-core/ycmd#808: write python used during build before installing completers; - PR ycm-core/ycmd#810: support unknown languages from tags; - PR ycm-core/ycmd#811: update Universal Ctags languages list; - PR ycm-core/ycmd#814: resolve symlinks in extra conf glob patterns; - PR ycm-core/ycmd#815: update JediHTTP; - PR ycm-core/ycmd#816: update Boost to 1.65.0; - PR ycm-core/ycmd#819: filter and sort candidates when query is empty; - PR ycm-core/ycmd#820: improve LLVM root path search for prebuilt binaries; - PR ycm-core/ycmd#822: inline critical utility functions; - PR ycm-core/ycmd#824: do not sort header paths in filename completer; - PR ycm-core/ycmd#825: implement partial sorting; - PR ycm-core/ycmd#830: add max_num_candidates option; - PR ycm-core/ycmd#831: fix multiline comments and strings issues; - PR ycm-core/ycmd#832: update Clang to 5.0.0. The `g:ycm_max_num_candidates` and `g:ycm_max_num_identifier_candidates` options are added to the documentation. The link to ycmd extra conf is updated. Fixes #2562. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2768) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ycmd compilation is successful but installing a completer fails, we don't create the
PYTHON_USED_DURING_BUILDINGfile. This can be an issue if the user gives up on the completer installation and the client uses the Python from this file to start ycmd (like YCM does). This could explain issue ycm-core/YouCompleteMe#2729.This change is