Skip to content

Commit

Permalink
Revert "When on an embedded page, bypass Getting Started gate check (e…
Browse files Browse the repository at this point in the history
…lastic#12040)"

This reverts commit 05293f1.
  • Loading branch information
ycombinator committed Jun 3, 2017
1 parent bd40b9d commit 360dfd7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,6 @@ describe('Getting Started page', () => {
set($route, 'current.$$route', {});
});

describe('if the user is on an embedded page', () => {
beforeEach(() => {
set($route, 'current.params.embed', true);
});

it('should not show the UI chrome', () => {
expect(uiChrome.getVisible()).to.be(false);
});
});

describe('if index patterns exist', () => {
beforeEach(() => {
config = {
Expand Down
5 changes: 0 additions & 5 deletions src/core_plugins/getting_started/public/lib/add_setup_work.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,6 @@ function showGettingStartedPage(kbnUrl, isOnGettingStartedPage) {
export function gettingStartedGateCheck(getIds, kbnUrl, config, $route) {
const currentRoute = get($route, 'current.$$route');
const isOnGettingStartedPage = get(currentRoute, 'originalPath') === GETTING_STARTED_ROUTE;
const isOnEmbeddedPage = Boolean(get($route, 'current.params.embed', false));

if (isOnEmbeddedPage) {
return Promise.resolve();
}

return getIds()
.then(indexPatterns => {
Expand Down

0 comments on commit 360dfd7

Please sign in to comment.