Extract RSpec Rails cops

[ydah]

No description provided.

[bquorning]

I tried diff'ing this code against a checkout of rubocop-factory_bot and rubocop-capybara, and it looks mostly ok. There are a few differences that I’ve tried to comment on.

[ydah]

I updated this PR.

[ydah]

I updated this PR.

[ydah]

@bquorning @pirj
As a result of the discussion at #1 (comment) , I've made the following changes, and I would appreciate your opinion.

• Add rubocop-rspec to runtime dependencies
  • Remove redundant files
• Add CI job to test rubocop-rspec edges

[pirj]

This is really close to readiness. Just one thing to reuse the config left. Thank you for the immense effort!

[ydah]

@pirj Thank you for your review! I updated this PR.

[bquorning]

I’m sorry for not having had the capacity to review your PR again.

[ydah]

@bquorning Don't worry about it. Thank you as always 😄 !

[pirj]

Thank you!

[pirj]

Should we make it depend on 2.28.0 where all cops are extracted to prevent duplicates? I can’t recall how we did this in the past.
Point to github from Gemfile to ensure edge, release this gem first, then release rubocop-rspec 2.28.0, then change this gemfile to remove github source and point to rubygems.
I haven’t had my morning coffee yet, so please take this idea with a grain of salt.

[ydah]

In the past we didn't need to worry about it, since rubocop-capybara and rubocop-factory_bot didn't rely on rubocop-rspec. Sorry. I want you to tell me, what kind of problem do I have if I don't depend on it after it's extracted?

[pirj]

In theory, it would be possible to install rubocop-rspec_rails 2.28.0 with rubocop-rapec 2.27.1, where the extraction didn’t happen yet.
It could happen, but seems unrealistic.
Other cases would be like the one we’ve had when we wanted to yank a certain version? In some circumstances, bundler can prefer to downgrade rubocop-rspec to this combination of versions.
rubocop/rubocop-rspec#1567

And, we should lick this to <3.0 here

[ydah]

Thank you. Indeed it is. I update this PR 1f412fd

[pirj]

Ah, I see, the version in edge is 2.27.1, so it won’t work to point to it.

@bquorning @Darhazer do you foresee any issues with the current approach?

[ydah]

@bquorning @pirj @Darhazer Now that all the problems have been solved, I will proceed with the extraction if there are no other problems.

[ydah]

Okay, I'm going to proceed with the extraction.

[ydah]

Commands:

git clone --no-local rubocop-rspec rubocop-rspec_rails-hist
cd rubocop-rspec_rails-hist
git-filter-repo $( (cat ../rubocop-rspec_rails/rename | xargs -I_ echo '--path-rename _ ') )
git-filter-repo $( (cd ../rubocop-rspec_rails && git ls-files) | xargs -I_ echo '--path _ ')
git remote add origin git@github.com:rubocop/rubocop-rspec_rails.git
git push --set-upstream origin master
cd ../rubocop-rspec_rails
cp -r * ../rubocop-rspec_rails-hist
cp -r $( git ls-files | grep '^\.' | grep -v '\.github' ) ../rubocop-rspec_rails-hist
cp -r .github ../rubocop-rspec_rails-hist
cd -
git commit --all --message 'RSpec -> RSpecRails'
bundle install
bundle exec rake
git push origin master

rename:

docs/modules/ROOT/pages/cops_rspec_rails.adoc:docs/modules/ROOT/pages/cops_rspecrails.adoc
rubocop-rspec.gemspec:rubocop-rspec_rails.gemspec
spec/rubocop/cop/rspec/rails/avoid_setup_hook_spec.rb:spec/rubocop/cop/rspec_rails/avoid_setup_hook_spec.rb
spec/rubocop/cop/rspec/rails/have_http_status_spec.rb:spec/rubocop/cop/rspec_rails/have_http_status_spec.rb
spec/rubocop/cop/rspec/rails/http_status_spec.rb:spec/rubocop/cop/rspec_rails/http_status_spec.rb
spec/rubocop/cop/rspec/rails/inferred_spec_type_spec.rb:spec/rubocop/cop/rspec_rails/inferred_spec_type_spec.rb
spec/rubocop/cop/rspec/rails/minitest_assertions_spec.rb:spec/rubocop/cop/rspec_rails/minitest_assertions_spec.rb
spec/rubocop/cop/rspec/rails/negation_be_valid_spec.rb:spec/rubocop/cop/rspec_rails/negation_be_valid_spec.rb
spec/rubocop/cop/rspec/rails/travel_around_spec.rb:spec/rubocop/cop/rspec_rails/travel_around_spec.rb
lib/rubocop-rspec.rb:lib/rubocop-rspec_rails.rb
lib/rubocop/cop/rspec/rails/avoid_setup_hook.rb:lib/rubocop/cop/rspec_rails/avoid_setup_hook.rb
lib/rubocop/cop/rspec/rails/have_http_status.rb:lib/rubocop/cop/rspec_rails/have_http_status.rb
lib/rubocop/cop/rspec/rails/http_status.rb:lib/rubocop/cop/rspec_rails/http_status.rb
lib/rubocop/cop/rspec/rails/inferred_spec_type.rb:lib/rubocop/cop/rspec_rails/inferred_spec_type.rb
lib/rubocop/cop/rspec/rails/minitest_assertions.rb:lib/rubocop/cop/rspec_rails/minitest_assertions.rb
lib/rubocop/cop/rspec/rails/negation_be_valid.rb:lib/rubocop/cop/rspec_rails/negation_be_valid.rb
lib/rubocop/cop/rspec/rails/travel_around.rb:lib/rubocop/cop/rspec_rails/travel_around.rb
lib/rubocop/cop/rspec_cops.rb:lib/rubocop/cop/rspec_rails_cops.rb
lib/rubocop/rspec/config_formatter.rb:lib/rubocop/rspec_rails/config_formatter.rb
lib/rubocop/rspec/description_extractor.rb:lib/rubocop/rspec_rails/description_extractor.rb
lib/rubocop/rspec/version.rb:lib/rubocop/rspec_rails/version.rb