Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring #65

Closed
romainx opened this issue Nov 1, 2017 · 3 comments
Closed

Code refactoring #65

romainx opened this issue Nov 1, 2017 · 3 comments
Assignees

Comments

@romainx
Copy link
Contributor

romainx commented Nov 1, 2017

Hello,

I would like to perform a code refactoring in order to split the big base.py module in several modules with separated concerns:

  • plot: Dedicated to plot features (histograms at this time)
  • describe: Dedicated to compute the variables description
  • report: Dedicated to generate the report
  • base: Containing only remaining common features

Additional modules will be ket as is.

  • formatters: Containing formatting utilities
  • templates: Jinja templating helpers and definition

It's just a first step, then I would like to split the big report generation, but this is another story ;-)

I would like your approval before starting it, since it will change a lot of things.

Many thanks for your answer.
Best,
Romain

@JosPolfliet
Copy link
Contributor

Sounds like a good idea. It has grown a bit out of the reasonable module length, for sure. If you submit I pull request I will review and check if all works as supposed to. The automated tox tests can help too, but they only find functional errors, no aesthetical errors.

@romainx romainx self-assigned this Nov 4, 2017
@romainx
Copy link
Contributor Author

romainx commented Nov 4, 2017

Great! I will work on it carefully and let you know.

romainx added a commit to romainx/pandas-profiling that referenced this issue Jan 1, 2018
romainx added a commit to romainx/pandas-profiling that referenced this issue Jan 1, 2018
* ydataai#68: Backport the fix
* ydataai#65: Describe module refactored
romainx added a commit to romainx/pandas-profiling that referenced this issue Jan 1, 2018
romainx added a commit that referenced this issue Jan 1, 2018
@romainx
Copy link
Contributor Author

romainx commented Jan 1, 2018

I close this issue since the main work has been done. I will open other PR in order to perform other refactoring tasks.

@romainx romainx closed this as completed Jan 1, 2018
chanedwin pushed a commit to chanedwin/pandas-profiling that referenced this issue Oct 11, 2020
chanedwin pushed a commit to chanedwin/pandas-profiling that referenced this issue Oct 11, 2020
* ydataai#68: Backport the fix
* ydataai#65: Describe module refactored
chanedwin pushed a commit to chanedwin/pandas-profiling that referenced this issue Oct 11, 2020
chanedwin pushed a commit to chanedwin/pandas-profiling that referenced this issue Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants