Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comparison alerts #1229

Merged
merged 2 commits into from Dec 30, 2022
Merged

fix: comparison alerts #1229

merged 2 commits into from Dec 30, 2022

Conversation

alexbarros
Copy link
Contributor

@alexbarros alexbarros commented Dec 29, 2022

Fix the error:
jinja2.exceptions.UndefinedError: 'None' has no attribute 'alert_type'
This error is triggered when comparing datasets that don't have the same set of alerts.

@codecov-commenter
Copy link

Codecov Report

Base: 90.64% // Head: 90.61% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (0f71473) compared to base (ef90115).
Patch coverage: 80.00% of modified lines in pull request are covered.

❗ Current head 0f71473 differs from pull request most recent head 820cfa5. Consider uploading reports for the commit 820cfa5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1229      +/-   ##
===========================================
- Coverage    90.64%   90.61%   -0.04%     
===========================================
  Files          186      186              
  Lines         5647     5667      +20     
===========================================
+ Hits          5119     5135      +16     
- Misses         528      532       +4     
Flag Coverage Δ
py3.8-ubuntu-latest-pandas 90.61% <80.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pandas_profiling/compare_reports.py 85.33% <78.94%> (-0.93%) ⬇️
src/pandas_profiling/model/alerts.py 95.23% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexbarros alexbarros merged commit ab93055 into develop Dec 30, 2022
@alexbarros alexbarros deleted the fix/comparison_alerts branch December 30, 2022 11:50
aquemy pushed a commit that referenced this pull request Jan 2, 2023
* fix: compare fail if alerts are not in all reports
aquemy pushed a commit that referenced this pull request Jan 2, 2023
* fix: compare fail if alerts are not in all reports
Sohaib90 pushed a commit to Sohaib90/pandas-profiling that referenced this pull request Jan 20, 2023
* fix: compare fail if alerts are not in all reports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants