fix(synths): Save and load methods not working. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fabclmnt
commented
Aug 17, 2021
fabclmnt
commented
- Save and load methods where not working as it was not possible to pickle the optimisers for the DRAGAN, WGAN and WGANGP.
- Optimisers where removed from the class attributes.
fabclmnt
changed the title
fabclmnt
changed the title
fabclmnt
added a commit
that referenced
this pull request
Aug 27, 2021
* feat: Input parameters entity (#74) * feat(synth): Change synthesizers input - Add Model and Train parameters as namedTuples. * feat(examples): Change examples inputs to match changes. * feat: Change CGAN and WGAN examples. * feat: Changing GAN parameters. * feat: Chaing DRAGAN inputs and example file. * feat(synth): Change learning rate inputs. * feat: Introduce the concept of epochs. * fix: Adding stock data dataset. * feat: Adding test datasets. * fix: Save and load methods from DRAGAN, WGAN and WGANGP. (#75) * fix: Save and load methods from DRAGAN, WGAN and WGANGP. (#75) * fix(TimeGAN): supervised loss computation (#77) * removing unused argument in build methods * Fixed supervisor loss temporal alignment * temporal allignment fix, path fix on example * path fix on example ipynb * docs: add contributing, support and license and minor changes (#78) * minor changes on quick start and project resources * add contributing guidelines * add support and licensing info * fix: Custom loss function. Example update. (#79) Co-authored-by: Francisco Santos <36741643+jfsantos-ds@users.noreply.github.com> Co-authored-by: Arunn Thevapalan <arunn.work@gmail.com>
fabclmnt
added a commit
that referenced
this pull request
Aug 27, 2021
* feat: Input parameters entity (#74) * feat(synth): Change synthesizers input - Add Model and Train parameters as namedTuples. * feat(examples): Change examples inputs to match changes. * feat: Change CGAN and WGAN examples. * feat: Changing GAN parameters. * feat: Chaing DRAGAN inputs and example file. * feat(synth): Change learning rate inputs. * feat: Introduce the concept of epochs. * fix: Adding stock data dataset. * feat: Adding test datasets. * fix: Save and load methods from DRAGAN, WGAN and WGANGP. (#75) * fix: Save and load methods from DRAGAN, WGAN and WGANGP. (#75) * fix(TimeGAN): supervised loss computation (#77) * removing unused argument in build methods * Fixed supervisor loss temporal alignment * temporal allignment fix, path fix on example * path fix on example ipynb * docs: add contributing, support and license and minor changes (#78) * minor changes on quick start and project resources * add contributing guidelines * add support and licensing info * fix: Custom loss function. Example update. (#79) Co-authored-by: Francisco Santos <36741643+jfsantos-ds@users.noreply.github.com> Co-authored-by: Arunn Thevapalan <arunn.work@gmail.com>
fabclmnt
added a commit
that referenced
this pull request
Aug 27, 2021
* feat: Input parameters entity (#74) * feat(synth): Change synthesizers input - Add Model and Train parameters as namedTuples. * feat(examples): Change examples inputs to match changes. * feat: Change CGAN and WGAN examples. * feat: Changing GAN parameters. * feat: Chaing DRAGAN inputs and example file. * feat(synth): Change learning rate inputs. * feat: Introduce the concept of epochs. * fix: Adding stock data dataset. * feat: Adding test datasets. * fix: Save and load methods from DRAGAN, WGAN and WGANGP. (#75) * fix: Save and load methods from DRAGAN, WGAN and WGANGP. (#75) * fix(TimeGAN): supervised loss computation (#77) * removing unused argument in build methods * Fixed supervisor loss temporal alignment * temporal allignment fix, path fix on example * path fix on example ipynb * docs: add contributing, support and license and minor changes (#78) * minor changes on quick start and project resources * add contributing guidelines * add support and licensing info * fix: Custom loss function. Example update. (#79) Co-authored-by: Francisco Santos <36741643+jfsantos-ds@users.noreply.github.com> Co-authored-by: Arunn Thevapalan <arunn.work@gmail.com>
jfsantos-ds
added a commit
that referenced
this pull request
Oct 18, 2021
* feat: Input parameters entity (#74) * feat(synth): Change synthesizers input - Add Model and Train parameters as namedTuples. * feat(examples): Change examples inputs to match changes. * feat: Change CGAN and WGAN examples. * feat: Changing GAN parameters. * feat: Chaing DRAGAN inputs and example file. * feat(synth): Change learning rate inputs. * feat: Introduce the concept of epochs. * fix: Adding stock data dataset. * feat: Adding test datasets. * fix: Save and load methods from DRAGAN, WGAN and WGANGP. (#75) * fix: Save and load methods from DRAGAN, WGAN and WGANGP. (#75) * fix(TimeGAN): supervised loss computation (#77) * removing unused argument in build methods * Fixed supervisor loss temporal alignment * temporal allignment fix, path fix on example * path fix on example ipynb * docs: add contributing, support and license and minor changes (#78) * minor changes on quick start and project resources * add contributing guidelines * add support and licensing info * fix: Custom loss function. Example update. (#79) Co-authored-by: Francisco Santos <36741643+jfsantos-ds@users.noreply.github.com> Co-authored-by: Arunn Thevapalan <arunn.work@gmail.com>
jfsantos-ds
added a commit
that referenced
this pull request
Oct 18, 2021
* feat: Input parameters entity (#74) * feat(synth): Change synthesizers input - Add Model and Train parameters as namedTuples. * feat(examples): Change examples inputs to match changes. * feat: Change CGAN and WGAN examples. * feat: Changing GAN parameters. * feat: Chaing DRAGAN inputs and example file. * feat(synth): Change learning rate inputs. * feat: Introduce the concept of epochs. * fix: Adding stock data dataset. * feat: Adding test datasets. * fix: Save and load methods from DRAGAN, WGAN and WGANGP. (#75) * fix: Save and load methods from DRAGAN, WGAN and WGANGP. (#75) * fix(TimeGAN): supervised loss computation (#77) * removing unused argument in build methods * Fixed supervisor loss temporal alignment * temporal allignment fix, path fix on example * path fix on example ipynb * docs: add contributing, support and license and minor changes (#78) * minor changes on quick start and project resources * add contributing guidelines * add support and licensing info * fix: Custom loss function. Example update. (#79) Co-authored-by: Francisco Santos <36741643+jfsantos-ds@users.noreply.github.com> Co-authored-by: Arunn Thevapalan <arunn.work@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.