feat: Add CGAN for timeseries #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabclmnt
reviewed
Nov 3, 2021
jfsantos-ds
commented
Nov 4, 2021
| @@ -1,45 +1,46 @@ | |||
| # Inverts all preprocessing pipelines provided in the preprocessing examples | |||
There was a problem hiding this comment.
Changes in this script consist in extending the inverse support to the MinMaxScaler
jfsantos-ds
commented
Nov 4, 2021
| @@ -2,17 +2,30 @@ | |||
| Get the stock data from Yahoo finance data | |||
There was a problem hiding this comment.
Allowing subsetting of columns
jfsantos-ds
commented
Nov 4, 2021
| @@ -4,7 +4,7 @@ | |||
| import numpy as np | |||
There was a problem hiding this comment.
Enabling inverse_transform of the timeseries scaler (processor needs to be returned here)
jfsantos-ds
commented
Nov 4, 2021
fabclmnt
reviewed
Nov 5, 2021
src/ydata_synthetic/postprocessing/timeseries/inverse_preprocesser.py
Outdated
Show resolved
Hide resolved
fabclmnt
reviewed
Nov 8, 2021
added 5 commits
December 15, 2021 18:17
remove changes on gitignore removed unused n_feats argument
apply revisions
Auto regressive timeseries sampling method revert TS data processor integration
jfsantos-ds
force-pushed
the
feat/tscwgan
branch
from
efa508a
to
a3c9b34
Compare
jfsantos-ds
commented
May 26, 2022
| data_.append(records) | ||
| data_ = hstack(data_)[:, :seq_len] | ||
| data.append(data_) | ||
| return array(vstack(data)) |
There was a problem hiding this comment.
Regarding to a revision of this sample method I think:
- We can force the number of samples to be the same as requested, i.e. truncate the last batch if needed
- Condition converted to tensor could be taken outside the for loop
- It does not seem to be truly auto-regressive since only the condition part of the produced records is being used as condition, we can add this capacity
Do you agree/have anything to add @fabclmnt ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93