-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Generic data processor #117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabclmnt
reviewed
Nov 8, 2021
fabclmnt
reviewed
Nov 8, 2021
fabclmnt
reviewed
Nov 9, 2021
cat_cols (list of strings): | ||
List of names of categorical columns | ||
""" | ||
def __init__(self, *, num_cols: List[str] = None, cat_cols: List[str] = None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing docstrings
fabclmnt
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
jfsantos-ds
added a commit
that referenced
this pull request
Dec 8, 2021
* data_processor mvp * add more typings * one output missing typing * remove redundant fit_transform method * typecheck simplifications * add cols positional index support to DataProcessor * add base processor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a generic data processor to cover synthesizer examples.
This processor is integrated in the ydata synthetic examples to simplify the data processing pipelines.
The preprocessor can be passed to the synthesizers in order to enable the following behaviors:
Closes #113