Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generic data processor #117

Merged
merged 7 commits into from
Nov 19, 2021
Merged

feat: Generic data processor #117

merged 7 commits into from
Nov 19, 2021

Conversation

jfsantos-ds
Copy link
Contributor

Adds a generic data processor to cover synthesizer examples.

This processor is integrated in the ydata synthetic examples to simplify the data processing pipelines.
The preprocessor can be passed to the synthesizers in order to enable the following behaviors:

  • Transform the raw data directly in synthesizer train method
  • Make the inverse_transform method of the preprocessor available to the synthesizer sample method, so that synthetic observations can be returned directly in the original format

Closes #113

@jfsantos-ds jfsantos-ds self-assigned this Nov 8, 2021
cat_cols (list of strings):
List of names of categorical columns
"""
def __init__(self, *, num_cols: List[str] = None, cat_cols: List[str] = None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docstrings

@fabclmnt fabclmnt linked an issue Nov 9, 2021 that may be closed by this pull request
@jfsantos-ds jfsantos-ds marked this pull request as ready for review November 16, 2021 21:39
Copy link
Contributor

@fabclmnt fabclmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jfsantos-ds jfsantos-ds merged commit 08d3cae into dev Nov 19, 2021
@jfsantos-ds jfsantos-ds deleted the feat/data_processor branch November 19, 2021 09:44
jfsantos-ds added a commit that referenced this pull request Dec 8, 2021
* data_processor mvp

* add more typings

* one output missing typing

* remove redundant fit_transform method

* typecheck simplifications

* add cols positional index support to DataProcessor

* add base processor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants