limit the number of connect attempts for cached tablet in volume proxy #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yegorskii
changed the title
qkrorlqr
requested changes
Mar 26, 2024
qkrorlqr
reviewed
Apr 2, 2024
qkrorlqr
reviewed
Apr 2, 2024
qkrorlqr
approved these changes
Apr 2, 2024
BarkovBG
approved these changes
Apr 3, 2024
yegorskii
deleted the
users/yegorskii/reset-tablet-cache-on-multiple-failures
branch
yegorskii
added a commit
that referenced
this pull request
Apr 3, 2024
#799) * limit the number of connect attemptr for cached tablet in volume proxy * update default * update * switch from count to duration * rearrange code * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to limit the number of attempts to connect to tablet before falling back to describe volume tablet in volume proxy. Now there is a way to cache disk-to-tablet mapping in volume proxy. For such tablets we do not resolve tablet if pipe desconnects assuming that it will recover. However it is possible that disk could be deleted and we will never recognize this situation, always replying with E_REJECTED. To handle such situation, a new config parameter introduced, limiting the time frame of attempts to connect without describing the tablet disk.