Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable funlen linter (part 5) #1232

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

brojeg
Copy link

@brojeg brojeg commented May 16, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: 934

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 73.77049% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 41.09%. Comparing base (b7a9b51) to head (71ed802).
Report is 128 commits behind head on master.

Files Patch % Lines
internal/pool/pool.go 76.27% 12 Missing and 2 partials ⚠️
log/driver.go 0.00% 1 Missing ⚠️
log/topic.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1232      +/-   ##
==========================================
+ Coverage   40.80%   41.09%   +0.29%     
==========================================
  Files         309      312       +3     
  Lines       32747    33220     +473     
==========================================
+ Hits        13361    13651     +290     
- Misses      18959    19108     +149     
- Partials      427      461      +34     
Flag Coverage Δ
go-1.21.x 43.23% <73.77%> (+0.29%) ⬆️
go-1.22.x 41.08% <73.77%> (+0.29%) ⬆️
macOS 40.57% <72.54%> (+0.27%) ⬆️
ubuntu 40.55% <72.54%> (+0.25%) ⬆️
unit 41.09% <73.77%> (+0.29%) ⬆️
windows 41.07% <73.77%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -88,9 +88,7 @@ func (c *Static) Token(ctx context.Context) (token string, err error) {
)
}
defer cc.Close()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove empty lines.

They separate the code into logical blocks for better readability.

@asmyasnikov asmyasnikov merged commit 56a634a into ydb-platform:master May 29, 2024
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants