Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standart exception classes for detecting retryable problems #35

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

alex268
Copy link
Member

@alex268 alex268 commented Dec 1, 2023

No description provided.

@alex268 alex268 self-assigned this Dec 1, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (c7a2ea6) 76.30% compared to head (80c07ff) 76.33%.

Files Patch % Lines
...main/java/tech/ydb/jdbc/settings/YdbJdbcTools.java 25.00% 6 Missing ⚠️
...java/tech/ydb/jdbc/exception/ExceptionFactory.java 54.54% 3 Missing and 2 partials ⚠️
.../exception/YdbConditionallyRetryableException.java 0.00% 4 Missing ⚠️
...tech/ydb/jdbc/exception/YdbRetryableException.java 0.00% 4 Missing ⚠️
...main/java/tech/ydb/jdbc/common/MappingSetters.java 0.00% 2 Missing ⚠️
...c/main/java/tech/ydb/jdbc/context/YdbExecutor.java 77.77% 2 Missing ⚠️
...a/tech/ydb/jdbc/impl/YdbPreparedStatementImpl.java 0.00% 2 Missing ⚠️
.../java/tech/ydb/jdbc/exception/YdbSQLException.java 75.00% 1 Missing ⚠️
...va/tech/ydb/jdbc/impl/YdbDatabaseMetaDataImpl.java 50.00% 0 Missing and 1 partial ⚠️
...rc/main/java/tech/ydb/jdbc/impl/YdbJdbcParams.java 0.00% 1 Missing ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release_v2.0.4      #35      +/-   ##
====================================================
+ Coverage             76.30%   76.33%   +0.02%     
+ Complexity             1571     1567       -4     
====================================================
  Files                    59       55       -4     
  Lines                  4123     4107      -16     
  Branches                451      453       +2     
====================================================
- Hits                   3146     3135      -11     
+ Misses                  773      768       -5     
  Partials                204      204              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex268 alex268 merged commit 12063ff into ydb-platform:release_v2.0.4 Dec 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants