Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added relocations for shaded JAR #54

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

alex268
Copy link
Member

@alex268 alex268 commented May 22, 2024

No description provided.

@alex268 alex268 requested a review from zinal May 22, 2024 08:01
@alex268 alex268 self-assigned this May 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.53%. Comparing base (e2c2d55) to head (6964f9d).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #54   +/-   ##
=========================================
  Coverage     76.53%   76.53%           
  Complexity     1594     1594           
=========================================
  Files            53       53           
  Lines          4266     4266           
  Branches        429      429           
=========================================
  Hits           3265     3265           
  Misses          784      784           
  Partials        217      217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zinal zinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.
epoll/netty story (which does not work now) should probably be handled separately, through the performance test

@alex268 alex268 merged commit 528d83f into ydb-platform:master May 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants