You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not for changelog (changelog entry is not required)
Additional information
vector.his included transitively via library/cpp/http/io/headers.h, but headers.h doesn't use it.
Currently it's impossible to remove this unused include, because it breaks compilation of ydb/library/http_proxy/authorization/signature.cpp
Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!
⚪ 2024-05-15 18:58:47 UTC Pre-commit check for 4b18c31 has started.
⚪ 2024-05-15 18:58:49 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-15 19:01:42 UTC Build successful.
⚪ 2024-05-15 19:00:06 UTC Pre-commit check for 4b18c31 has started.
⚪ 2024-05-15 19:00:08 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-15 19:01:27 UTC Build successful.
⚪ 2024-05-15 19:03:21 UTC Tests are running...
🔴 2024-05-15 20:15:07 UTC Some tests failed, follow the links below.
⚪ 2024-05-15 19:00:32 UTC Pre-commit check for 4b18c31 has started.
⚪ 2024-05-15 19:00:35 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-15 19:02:04 UTC Build successful.
⚪ 2024-05-15 19:03:57 UTC Tests are running...
🔴 2024-05-15 20:48:44 UTC Some tests failed, follow the links below.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maximyurchuk
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
Changelog entry
Add missing includes
Changelog category
Additional information
vector.his included transitively vialibrary/cpp/http/io/headers.h, butheaders.hdoesn't use it.Currently it's impossible to remove this unused include, because it breaks compilation of
ydb/library/http_proxy/authorization/signature.cpp