Completion of the transaction #4407
Conversation
|
⚪
|
|
⚪
|
ydb/core/persqueue/pq_impl.cpp
Outdated
| void TPersQueue::Handle(TEvPQ::TEvDeletePartitionDone::TPtr& ev, const TActorContext& ctx) | ||
| { | ||
| auto* event = ev->Get(); | ||
| const ui64 writeId = event->Cookie; |
There was a problem hiding this comment.
Return writeId in EvDeletePartitionDone response, no Cookie field required anymore.
There was a problem hiding this comment.
PartitionId is used instead of WriteId
76c2d74
ydb/core/persqueue/pq_impl.cpp
Outdated
| Y_ABORT_UNLESS(Partitions.contains(partitionId)); | ||
| const TPartitionInfo& partition = Partitions.at(partitionId); | ||
|
|
||
| Send(partition.Actor, new TEvents::TEvPoisonPill()); |
There was a problem hiding this comment.
Call die() or PassAway() in partition actor on sending EvDeletePartitionDone.
There was a problem hiding this comment.
Done
1b4b028
ydb/core/persqueue/partition.cpp
Outdated
|
|
||
| void TPartition::ScheduleNegativeReply(const TEvPQ::TEvSetClientInfo&) | ||
| { | ||
| Y_ABORT_UNLESS(false, "The supportive partition does not accept read operations"); |
There was a problem hiding this comment.
Fixed
8b94486
ydb/core/persqueue/partition.h
Outdated
| @@ -91,6 +91,10 @@ class TPartition : public TActorBootstrapped<TPartition> { | |||
| static const ui32 MAX_ERRORS_COUNT_TO_STORE = 10; | |||
| static const ui32 SCALE_REQUEST_REPEAT_MIN_SECONDS = 60; | |||
|
|
|||
| enum ECookie : ui64 { | |||
There was a problem hiding this comment.
Done
76c2d74
ydb/core/persqueue/partition.h
Outdated
| @@ -795,6 +804,19 @@ class TPartition : public TActorBootstrapped<TPartition> { | |||
| bool ClosedInternalPartition = false; | |||
|
|
|||
| bool IsSupportive() const; | |||
|
|
|||
| ui64 DeletePartitionCookie = 0; | |||
There was a problem hiding this comment.
Change to ENUM:
DELETEION_NOT_INITED
DELETION_INITED
DELETION_IN_PROCESS
There was a problem hiding this comment.
Done
76c2d74
| @@ -483,10 +483,12 @@ class TPersQueue : public NKeyValue::TKeyValueFlat { | |||
| void CreateSupportivePartitionActor(const TPartitionId& shadowPartitionId, const TActorContext& ctx); | |||
| NKikimrPQ::TPQTabletConfig MakeSupportivePartitionConfig() const; | |||
| void SubscribeWriteId(ui64 writeId, const TActorContext& ctx); | |||
| void UnsubscribeWriteId(ui64 writeId, const TActorContext& ctx); | |||
There was a problem hiding this comment.
No EvDeletePartition called!
|
⚪
|
|
⚪
|
|
⚪ |
|
⚪ |
|
⚪ |
Alek5andr-Kotov
force-pushed
the
LOGBROKER-8897
branch
from
f22b220
to
1b4b028
Compare
|
⚪
|
|
⚪
|
Alek5andr-Kotov
force-pushed
the
LOGBROKER-8897
branch
from
1b4b028
to
f0d7ba3
Compare
|
⚪
|
|
⚪
|
|
⚪
|
|
⚪
|
| NPQ::AddCmdDeleteRange(request, TKeyPrefix::TypeInfo, Partition); | ||
| NPQ::AddCmdDeleteRange(request, TKeyPrefix::TypeData, Partition); | ||
| NPQ::AddCmdDeleteRange(request, TKeyPrefix::TypeTmpData, Partition); | ||
| NPQ::AddCmdDeleteRange(request, TKeyPrefix::TypeMeta, Partition); |
Changelog entry
Added the TEvDeletePartition, TEvDeletePartitionDone and TEvTransactionCompleted messages. Upon completion of the transaction, the PQ tablet sends TEvDeletePartition to the auxiliary partitions and waits for TEvDeletePartitionDone from them
Changelog category
Additional information
...