Yql 18391 gracejoin spilling support #4700

lll-phill-lll · 2024-05-20T19:06:50Z

Changelog entry

This PR adds support for spilling in grace join.
...

Changelog category

New feature

Additional information

...

github-actions · 2024-05-20T19:10:09Z

⚪ 2024-05-20 19:10:08 UTC Pre-commit check for cb3e1eb has started.
⚪ 2024-05-20 19:10:11 UTC Build linux-x86_64-release-asan is running...
🔴 2024-05-20 19:12:31 UTC Build failed. see the build logs.
⚫ 2024-05-20 19:13:30 UTC Check cancelled

github-actions · 2024-05-20T19:10:12Z

⚪ 2024-05-20 19:10:12 UTC Pre-commit check for cb3e1eb has started.
⚪ 2024-05-20 19:10:14 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-20 19:12:15 UTC Build failed. see the build logs.

github-actions · 2024-05-20T19:10:21Z

⚪ 2024-05-20 19:10:21 UTC Pre-commit check for cb3e1eb has started.
⚪ 2024-05-20 19:10:24 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-05-20 19:12:32 UTC Build failed. see the build logs.
⚫ 2024-05-20 19:13:31 UTC Check cancelled

github-actions · 2024-05-20T19:16:57Z

⚪ 2024-05-20 19:16:56 UTC Pre-commit check for b57eb16 has started.
⚪ 2024-05-20 19:16:59 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-20 19:20:23 UTC Build successful.

github-actions · 2024-05-20T19:16:59Z

⚪ 2024-05-20 19:16:58 UTC Pre-commit check for b57eb16 has started.
⚪ 2024-05-20 19:17:01 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-20 19:20:00 UTC Build successful.
⚪ 2024-05-20 19:21:51 UTC Tests are running...
🔴 2024-05-20 21:16:13 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11770	11643	0	43	68	16

github-actions · 2024-05-20T19:17:07Z

⚪ 2024-05-20 19:17:07 UTC Pre-commit check for b57eb16 has started.
⚪ 2024-05-20 19:17:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-20 19:20:23 UTC Build successful.
⚪ 2024-05-20 19:22:05 UTC Tests are running...
🔴 2024-05-20 21:07:10 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
70715	58023	0	2	12681	9

github-actions · 2024-05-21T08:12:35Z

⚪ 2024-05-21 08:12:35 UTC Pre-commit check for 90b1002 has started.
⚪ 2024-05-21 08:12:37 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-21 08:16:03 UTC Build successful.

github-actions · 2024-05-21T08:12:50Z

⚪ 2024-05-21 08:12:50 UTC Pre-commit check for 90b1002 has started.
⚪ 2024-05-21 08:12:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-21 08:15:49 UTC Build successful.
⚪ 2024-05-21 08:17:37 UTC Tests are running...
🔴 2024-05-21 10:17:04 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11767	11651	0	40	64	12

github-actions · 2024-05-21T08:22:38Z

⚪ 2024-05-21 08:22:38 UTC Pre-commit check for 90b1002 has started.
⚪ 2024-05-21 08:22:39 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-21 08:25:47 UTC Build successful.
⚪ 2024-05-21 08:27:32 UTC Tests are running...
🔴 2024-05-21 10:29:00 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
70737	58033	0	3	12692	9

github-actions · 2024-05-22T13:26:43Z

⚪ 2024-05-22 13:26:43 UTC Pre-commit check for e2ea41e has started.
⚪ 2024-05-22 13:26:46 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-22 13:29:38 UTC Build successful.
⚫ 2024-05-22 13:30:12 UTC Check cancelled

github-actions · 2024-05-22T13:26:56Z

⚪ 2024-05-22 13:26:56 UTC Pre-commit check for e2ea41e has started.
⚪ 2024-05-22 13:26:58 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-05-22 13:30:30 UTC Check cancelled

github-actions · 2024-05-22T13:28:21Z

⚪ 2024-05-22 13:28:21 UTC Pre-commit check for e2ea41e has started.
⚪ 2024-05-22 13:28:23 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-05-22 13:30:15 UTC Check cancelled

github-actions · 2024-05-22T13:31:44Z

⚪ 2024-05-22 13:31:44 UTC Pre-commit check for 471ba28 has started.
⚪ 2024-05-22 13:31:45 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-22 13:33:58 UTC Build successful.
⚪ 2024-05-22 13:38:00 UTC Tests are running...
🔴 2024-05-22 15:33:50 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11768	11651	0	44	62	11

github-actions · 2024-05-22T13:31:46Z

⚪ 2024-05-22 13:31:45 UTC Pre-commit check for 471ba28 has started.
⚪ 2024-05-22 13:31:47 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-22 13:34:56 UTC Build successful.
⚪ 2024-05-22 13:36:38 UTC Tests are running...
🔴 2024-05-22 15:33:14 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
70744	58037	0	2	12693	12

github-actions · 2024-05-22T13:33:38Z

⚪ 2024-05-22 13:33:37 UTC Pre-commit check for 471ba28 has started.
⚪ 2024-05-22 13:33:39 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-22 13:37:00 UTC Build successful.

ydb/library/yql/minikql/comp_nodes/mkql_grace_join.cpp

ydb/library/yql/minikql/comp_nodes/mkql_grace_join_imp.h

ydb/library/yql/minikql/comp_nodes/mkql_grace_join_imp.cpp

github-actions · 2024-05-23T06:43:08Z

⚪ 2024-05-23 06:43:08 UTC Pre-commit check for 541bb17 has started.
⚪ 2024-05-23 06:43:11 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-23 06:46:45 UTC Build successful.

github-actions · 2024-05-23T06:43:17Z

⚪ 2024-05-23 06:43:17 UTC Pre-commit check for 541bb17 has started.
⚪ 2024-05-23 06:43:20 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-23 06:46:10 UTC Build successful.
⚪ 2024-05-23 06:47:56 UTC Tests are running...
🔴 2024-05-23 08:55:02 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11783	11661	0	44	66	12

github-actions · 2024-05-23T06:45:22Z

⚪ 2024-05-23 06:45:21 UTC Pre-commit check for 541bb17 has started.
⚪ 2024-05-23 06:45:24 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-23 06:48:34 UTC Build successful.
⚪ 2024-05-23 06:50:19 UTC Tests are running...
🟢 2024-05-23 08:45:49 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
70786	58073	0	0	12708	5

lll-phill-lll added 3 commits May 20, 2024 19:52

YQL-18391 added spilling for grace join

2d47400

spilling part finished

45a9ab9

restore part finished

3b89df4

lll-phill-lll requested a review from a team as a code owner May 20, 2024 19:06

github-actions bot added the new-feature label May 20, 2024

fix build

08ae143

lll-phill-lll requested a review from Darych May 20, 2024 19:26

removed debug prints

607caa2

lll-phill-lll added 12 commits May 21, 2024 18:35

fetches everything without spilling

b433eec

fixup

f2bcd88

works

9235250

everything works

f3caeda

fixup

032d1f6

more unification

c533371

remove duplicate code

55e1419

remove duplicate code

81c97c9

removed debug prints

96080c9

small refactoring

6fea9e5

removed hardcoded spilling

214f67e

remove unnecessary changes

6d20ae0

remove unnecessary changes

71193aa

lll-phill-lll requested a review from resetius May 22, 2024 17:23

Darych reviewed May 22, 2024

View reviewed changes

review fixes

ad0b6ec

Darych approved these changes May 23, 2024

View reviewed changes

lll-phill-lll merged commit daae461 into ydb-platform:main May 23, 2024
4 of 5 checks passed

serbel324 mentioned this pull request May 24, 2024

Add description of new ICB controls for CMS #4818

Merged

This was referenced May 27, 2024

Cli changes for autoscaling #4871

Open

Fix getting mid of range for autoscaling #4884

Closed

Fix getting mid range #4885

Merged

MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024

Yql 18391 gracejoin spilling support (ydb-platform#4700)

b66ca3f

niksaveliev mentioned this pull request May 29, 2024

Autoscaling logs #4976

Merged

This was referenced May 29, 2024

YQ-3292 fixed kqprun ResourceBrokerConfig passing #4994

Merged

Added ExecutionId for script execution logs #5014

Merged

This was referenced May 30, 2024

Forbid autoscaling with size retention #5054

Merged

Mute split by load ut #5264

Closed

Mute split by load ut #5267

Closed

Mute split by load ut #5272

Merged

This was referenced Jun 7, 2024

Fix build #5310

Merged

Fix split by load ut #5383

Merged

niksaveliev mentioned this pull request Jun 17, 2024

Fix win build #5622

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Yql 18391 gracejoin spilling support #4700

Yql 18391 gracejoin spilling support #4700

lll-phill-lll commented May 20, 2024

github-actions bot commented May 20, 2024 •

edited

github-actions bot commented May 20, 2024 •

edited

github-actions bot commented May 20, 2024 •

edited

github-actions bot commented May 20, 2024 •

edited

github-actions bot commented May 20, 2024 •

edited

github-actions bot commented May 20, 2024 •

edited

github-actions bot commented May 21, 2024 •

edited

github-actions bot commented May 21, 2024 •

edited

github-actions bot commented May 21, 2024 •

edited

github-actions bot commented May 22, 2024 •

edited

github-actions bot commented May 22, 2024 •

edited

github-actions bot commented May 22, 2024 •

edited

github-actions bot commented May 22, 2024 •

edited

github-actions bot commented May 22, 2024 •

edited

github-actions bot commented May 22, 2024 •

edited

github-actions bot commented May 23, 2024 •

edited

github-actions bot commented May 23, 2024 •

edited

github-actions bot commented May 23, 2024 •

edited

Yql 18391 gracejoin spilling support #4700

Yql 18391 gracejoin spilling support #4700

Conversation

lll-phill-lll commented May 20, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented May 20, 2024 • edited

github-actions bot commented May 20, 2024 • edited

github-actions bot commented May 20, 2024 • edited

github-actions bot commented May 20, 2024 • edited

github-actions bot commented May 20, 2024 • edited

github-actions bot commented May 20, 2024 • edited

github-actions bot commented May 21, 2024 • edited

github-actions bot commented May 21, 2024 • edited

github-actions bot commented May 21, 2024 • edited

github-actions bot commented May 22, 2024 • edited

github-actions bot commented May 22, 2024 • edited

github-actions bot commented May 22, 2024 • edited

github-actions bot commented May 22, 2024 • edited

github-actions bot commented May 22, 2024 • edited

github-actions bot commented May 22, 2024 • edited

github-actions bot commented May 23, 2024 • edited

github-actions bot commented May 23, 2024 • edited

github-actions bot commented May 23, 2024 • edited

github-actions bot commented May 20, 2024 •

edited

github-actions bot commented May 20, 2024 •

edited

github-actions bot commented May 20, 2024 •

edited

github-actions bot commented May 20, 2024 •

edited

github-actions bot commented May 20, 2024 •

edited

github-actions bot commented May 20, 2024 •

edited

github-actions bot commented May 21, 2024 •

edited

github-actions bot commented May 21, 2024 •

edited

github-actions bot commented May 21, 2024 •

edited

github-actions bot commented May 22, 2024 •

edited

github-actions bot commented May 22, 2024 •

edited

github-actions bot commented May 22, 2024 •

edited

github-actions bot commented May 22, 2024 •

edited

github-actions bot commented May 22, 2024 •

edited

github-actions bot commented May 22, 2024 •

edited

github-actions bot commented May 23, 2024 •

edited

github-actions bot commented May 23, 2024 •

edited

github-actions bot commented May 23, 2024 •

edited