Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hc api doc #5703

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

StekPerepolnen
Copy link
Collaborator

@StekPerepolnen StekPerepolnen commented Jun 19, 2024

Changelog entry

hc api improvement

Changelog category

  • Documentation (changelog entry is not required)

Additional information

...

@StekPerepolnen StekPerepolnen requested a review from a team as a code owner June 19, 2024 08:28
@github-actions github-actions bot added new-feature documentation Improvements or additions to documentation labels Jun 19, 2024
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

ydb/docs/en/core/reference/ydb-sdk/health-check-api.md Outdated Show resolved Hide resolved
ydb/docs/en/core/reference/ydb-sdk/health-check-api.md Outdated Show resolved Hide resolved
ydb/docs/en/core/reference/ydb-sdk/health-check-api.md Outdated Show resolved Hide resolved
ydb/docs/en/core/reference/ydb-sdk/health-check-api.md Outdated Show resolved Hide resolved
ydb/docs/en/core/reference/ydb-sdk/health-check-api.md Outdated Show resolved Hide resolved
ydb/docs/en/core/reference/ydb-sdk/health-check-api.md Outdated Show resolved Hide resolved
ydb/docs/en/core/reference/ydb-sdk/health-check-api.md Outdated Show resolved Hide resolved
ydb/docs/en/core/reference/ydb-sdk/health-check-api.md Outdated Show resolved Hide resolved
ydb/docs/en/core/reference/ydb-sdk/health-check-api.md Outdated Show resolved Hide resolved
ydb/docs/en/core/reference/ydb-sdk/health-check-api.md Outdated Show resolved Hide resolved
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Co-authored-by: Ivan Blinkov <ivan@blinkov.ru>
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

❌ Documentation build

Revision build failed

Build logs

Errors (1)

❌ /ru/reference/ydb-sdk/health-check-api.md: 77: YFM005/tab-list-not-closed Tab list not closed [Context: "Полный список дополнительных параметров представлен ниже:"]

Copy link

❌ Documentation build

Revision build failed

Build logs

Errors (1)

❌ /ru/reference/ydb-sdk/health-check-api.md: 78: YFM005/tab-list-not-closed Tab list not closed [Context: "Полный список дополнительных параметров представлен ниже:"]

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link
Member

@blinkov blinkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many comments from the previous iteration are not fixed

ydb/docs/en/core/reference/ydb-sdk/health-check-api.md Outdated Show resolved Hide resolved
ydb/docs/en/core/reference/ydb-sdk/health-check-api.md Outdated Show resolved Hide resolved
ydb/docs/en/core/reference/ydb-sdk/health-check-api.md Outdated Show resolved Hide resolved
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Comment on lines +160 to +161
## Example {#examples}
The shortest `HealthCheck` response looks like this. It is returned if there is nothing wrong with the database
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Example {#examples}
The shortest `HealthCheck` response looks like this. It is returned if there is nothing wrong with the database
## Example {#examples}
The shortest `HealthCheck` response looks like this. It is returned if there is nothing wrong with the database

| Parameter | Type | Description |
|:----|:----|:----|
| `ReturnVerboseStatus` | `bool` | As mentioned earlier, this parameter affects the filling of the `database_status` field. Default is false. |
| `MinimumStatus` | `EStatusFlag` | The minimum severity status that will appear in the response. Less severe issues will be discarded. By default, all issues will be listed. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a link to the list of possible EStatusFlag values

|:----|:----|:----|
| `ReturnVerboseStatus` | `bool` | As mentioned earlier, this parameter affects the filling of the `database_status` field. Default is false. |
| `MinimumStatus` | `EStatusFlag` | The minimum severity status that will appear in the response. Less severe issues will be discarded. By default, all issues will be listed. |
| `MaximumLevel` | `int32` | The maximum depth of issues in the response. Issues at deeper levels will be discarded. By default, all issues will be listed. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it signed? what do negative values mean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants