Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add few auto partitioning fields to describe and SDK. Add important consumer to CLI #6118

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add few auto partitioning fields to describe and SDK. Add important consumer to CLI #6118

wants to merge 2 commits into from
+109 −7

Conversation

niksaveliev
Copy link
Collaborator

@niksaveliev niksaveliev commented Jul 1, 2024 •
edited
Loading

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@niksaveliev niksaveliev changed the title Add auto partitioning bounds to SDK and important consumer to CLI Add few auto partitioning fields to describe and SDK. Add important consumer to CLI Jul 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

⚪ 2024-07-01 09:58:09 UTC Pre-commit check for 3b30cac has started.
⚪ 2024-07-01 10:01:37 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-01 10:43:37 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

⚪ 2024-07-01 10:41:33 UTC Pre-commit check for 3b30cac has started.
⚪ 2024-07-01 10:44:58 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-01 11:35:28 UTC Build successful.
⚪ 2024-07-01 11:35:43 UTC Tests are running...
🔴 2024-07-01 13:49:48 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15583 14952 0 107 352 172

🟢 2024-07-01 13:50:33 UTC ydbd size 5.4 GiB changed* by +54.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ddf20da merge: 3b30cac diff diff %
ydbd size 5 831 012 760 Bytes 5 831 068 296 Bytes +54.2 KiB +0.001%
ydbd stripped size 1 251 038 056 Bytes 1 251 045 896 Bytes +7.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

⚪ 2024-07-01 11:15:15 UTC Pre-commit check for 3b30cac has started.
⚪ 2024-07-01 11:18:38 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-01 12:26:09 UTC Build successful.
⚪ 2024-07-01 12:26:22 UTC Tests are running...
🔴 2024-07-01 14:59:06 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76528 63134 0 3 13379 12

🟢 2024-07-01 14:59:46 UTC ydbd size 8.3 GiB changed* by +35.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ddf20da merge: 3b30cac diff diff %
ydbd size 8 953 008 608 Bytes 8 953 045 080 Bytes +35.6 KiB +0.000%
ydbd stripped size 488 238 568 Bytes 488 239 624 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@niksaveliev niksaveliev marked this pull request as ready for review July 2, 2024 07:13
@niksaveliev niksaveliev requested a review from a team as a code owner July 2, 2024 07:13
nshestakov
nshestakov reviewed Jul 2, 2024
View reviewed changes
ydb/core/persqueue/ut/ut_with_sdk/autoscaling_ut.cpp
std::sort(childIds.begin(), childIds.end());
UNIT_ASSERT_EQUAL(childIds[0], 1);
UNIT_ASSERT_EQUAL(childIds[1], 2);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a break here

nshestakov
nshestakov previously approved these changes Jul 2, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

⚪ 2024-07-02 09:38:20 UTC Pre-commit check for 5285086 has started.
⚪ 2024-07-02 09:41:24 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-02 10:24:08 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

⚪ 2024-07-02 09:38:35 UTC Pre-commit check for 5285086 has started.
⚪ 2024-07-02 09:41:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-02 10:30:51 UTC Build successful.
⚪ 2024-07-02 10:31:07 UTC Tests are running...
🔴 2024-07-02 12:43:35 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15633 14989 0 123 348 173

🟢 2024-07-02 12:44:19 UTC ydbd size 5.4 GiB changed* by +53.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8bf9bed merge: 5285086 diff diff %
ydbd size 5 829 829 424 Bytes 5 829 884 608 Bytes +53.9 KiB +0.001%
ydbd stripped size 1 251 537 384 Bytes 1 251 545 160 Bytes +7.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

⚪ 2024-07-02 09:43:24 UTC Pre-commit check for 5285086 has started.
⚪ 2024-07-02 09:46:26 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-02 10:50:18 UTC Build successful.
⚪ 2024-07-02 10:50:34 UTC Tests are running...
🔴 2024-07-02 13:17:14 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76607 63207 0 3 13384 13

🟢 2024-07-02 13:18:03 UTC ydbd size 8.3 GiB changed* by +39.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8bf9bed merge: 5285086 diff diff %
ydbd size 8 946 683 664 Bytes 8 946 724 392 Bytes +39.8 KiB +0.000%
ydbd stripped size 487 864 872 Bytes 487 870 024 Bytes +5.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

spuchin
spuchin reviewed Jul 2, 2024
View reviewed changes
ydb/public/api/protos/ydb_topic.proto
@@ -1087,6 +1087,11 @@ message DescribeTopicResult {

// Partition location, filled only when include_location in request is true.
PartitionLocation partition_location = 6;

// Inclusive left border. Emptiness means -inf.
optional bytes from_bound = 7;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А что там внутри bytes?

Copy link
Collaborator Author

@niksaveliev niksaveliev Jul 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Строка. Но там могут быть нечитаемые символы, поэтому байты. Границы не человекочитаемы

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну вот непонятно как этим пользоваться тогда?
Какой формат, если это бинарные данные?
Что тут будет SDK/Describe возвращать?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дескрайб в SDK возвращает TString. Вот пример https://github.com/ydb-platform/ydb/pull/6118/files#diff-c7baefa581e4001940d02d8510c369295cc6c020f946c62bc1f1fdccdbd37e61R824

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Как пользоваться - лексикографически сравнивать. Можно, например, определить, лежит ли твой ключ в границах партиции просто сравнением

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spuchin spuchin spuchin left review comments

@nshestakov nshestakov nshestakov left review comments

@siarheivesialou siarheivesialou Awaiting requested review from siarheivesialou siarheivesialou is a code owner automatically assigned from ydb-platform/topics

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@niksaveliev @nshestakov @spuchin