Add a view menu with zoom actions #16
Conversation
Add the following actions: - Zoom in/out via menu (discoverability) - Reset zoom to default (800% currently) - Set zoom to 100%
|
More ideas:
|
tarsila/src/ui_state.rs
Outdated
| fn default() -> Self { | ||
| Self { default_zoom: 8. } | ||
| } | ||
| } |
There was a problem hiding this comment.
I do like the idea of a preferences object, and we will need it, but for now I think it would be better to use just a const on the top of the file for this config. The reason I say this is that there is a lot of configuration scattered across the program, so when we do decide to implement a preferences or settings type we need to consider also those other values. There are lots of other considerations that I might open a discussion thread or an issue for this. With the constants all on top of the files it will be relatively easy to collect them once we decide how to implement the preferences system.
There was a problem hiding this comment.
Alright, I'll change it to a const when I get home.
It actually started out as a const, but I thought I would follow up this with a PR that makes the default zoom configurable, but maybe that shouldn't have leaked into this PR.
There was a problem hiding this comment.
Alright, it's done. Let me know if you need any other change.
|
Thanks for taking the time to implement this very useful feature. I like the proposals to show the shortcuts in the menu items as well, I'd welcome other PRs doing this. The hover with extra information about the default zoom is also great. Please see my comment in the PR code -- with that approach we also don't need to pass any information (for now, this will change later) to the menu, we can just access the constant. |
|
Linking the preferences discussion thread: #17 |
|
Thank you! Merging |
Add the following actions: