Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0003: FB Authorization. More LaravelAPI-friendly code #1

Open
yeahframeoff opened this issue Jul 31, 2014 · 1 comment
Open

0003: FB Authorization. More LaravelAPI-friendly code #1

yeahframeoff opened this issue Jul 31, 2014 · 1 comment

Comments

@yeahframeoff
Copy link
Owner

I found it useful to make some review of your code as I see some aspects that would be critical when working.

  1. Could you make your app id and client server as some const variables outside the index method so that we soon can easily move them into app/config/app.php
  2. I would strongly recommend you use Session facade to work with session data instead of using native php method. That thing is critical because pure-php session_destroy() would delete some crucial extra data (e.g. "_token" in forms) stored by the Laravel framework.
  3. Could you please explain in simple words how the process goes in facebook? As I see, when user not logged follows the link, he sees request for access to his personal data. After that the browser is redirected and here the request should be caught by the controller and the access token should be extracted from the response. I'm wondering: does the facebook use this token to access the API method, or he needs some additional temporary token that is retrieved from the first token and that is used to make calls to api and that expires in some period of time?
  4. Could you please return results of View::make() as the result in the end of the method?
@yeahframeoff yeahframeoff changed the title 0003: FBauthorization. Refactor 0003: FB Authorization. More FrameworkAPI-friendly code Jul 31, 2014
yeahframeoff added a commit that referenced this issue Jul 31, 2014
Fixed problems 1, 2 issued in #1 .
@yeahframeoff yeahframeoff changed the title 0003: FB Authorization. More FrameworkAPI-friendly code 0003: FB Authorization. More LaravelAPI-friendly code Jul 31, 2014
@yeahframeoff
Copy link
Owner Author

I made some fixes in branch 0003-feature-develop-yeahframeoff-fix that solve the problems 1 and 2. Check them out and let me know what you think of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants