Added option to directly launch editor #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New preference choice: Screen Shot Choice - Default option opens preview
|
Hi @paipeng05, awesome! ❤️ But, don't take it personally, I think the choice of "Screen Shot Choice" isn't quite perfect. Could you change it to "After screenshot" as same as Shottr? I would like to add the option to copy directly to the clipboard in the future. |
|
Yes! I'll do it asap. I just couldn't think of a good name for it so just randomly thought of a temporary placeholder (think I had a TODO for thinking of a better name 😂). For "add the option to copy directly to the clipboard", do you mean that the screenshot will directly go to clipboard once the the mouse is let go of? |
Screen Shot Choice -> After Screenshot
Made the if else ifs... into a switch
- added third option to copy screenshot directly
|
Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion from #16
-> preference name can be easily changed in case of poor naming
-> no need for relaunch for change to work (checks preference every time snipped is emitted)