[WEB-1139-193] adds Shapeshift DAO router #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yearn-linear-gh-sync
bot
changed the title
|
Adding a link to our router implementation for reference - https://github.com/shapeshift/yearn-router/blob/development/contracts/ShapeShiftDAORouter.sol |
pandadefi
approved these changes
Jan 15, 2022
|
@0xean PR lgtm, could you just rebase to resolve the merge conflicts so we can get this merged? |
0xean
force-pushed
the
feature/add-shapeshift-router
branch
from
6709da2
to
2f805ab
Compare
|
@BobTheBuidler - updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the newly deployed Shapeshift DAO Router (0x90a48d5cf7343b08da12e067680b4c6dbfe551be) to the partners list.
Our router is loosely based on the examples provided by Yearn and call's the vault deposit method directly passing the vault tokens to the recipient that is not our contract.
Is there an easy way to confirm the WildCardWrapper will be functional with this implementation?
Thank you!