Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate Limiting algorithm doesn't work under status change events #11

Closed
2 tasks
fubuloubu opened this issue Oct 14, 2020 · 1 comment · Fixed by #173
Closed
2 tasks

Rate Limiting algorithm doesn't work under status change events #11

fubuloubu opened this issue Oct 14, 2020 · 1 comment · Fixed by #173
Assignees
@fubuloubu
Labels
enhancement New feature or request p2 important

Comments

@fubuloubu
Copy link
Member

  • Emergency exit from False to Truegives the rate limit from the last block reported (which is earlier than when the reset happens)
  • reseting debt limit on a strategy back to nonzero value (following revokeStrategy) uses the last block reported (which is earlier than when the reset happens)
@fubuloubu
Copy link
Member Author

Idea: add Vault.lastGlobalEvent and Vault.StrategyParams.lastChangeEvent, and then do max of those and the last sync

@fubuloubu fubuloubu self-assigned this Oct 14, 2020
@milkyklim milkyklim added the enhancement New feature or request label Oct 21, 2020
This was referenced Jan 28, 2021
Closed
Merged
@saltyfacu saltyfacu added the p2 important label Feb 4, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fubuloubu fubuloubu

Labels
enhancement New feature or request p2 important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: change "rate limit" feature to min/max harvest debt size params yearn/yearn-vaults
3 participants
@saltyfacu @fubuloubu @milkyklim