Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistent Liquidations in BaseStrategy Emergency Exit Mode #311

Merged
merged 2 commits into from May 16, 2021
Merged

fix: inconsistent Liquidations in BaseStrategy Emergency Exit Mode #311

merged 2 commits into from May 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 30, 2021

fixes #229

@ghost ghost requested a review from fubuloubu May 3, 2021 09:45
contracts/BaseStrategy.sol Outdated Show resolved Hide resolved
contracts/BaseStrategy.sol Outdated Show resolved Hide resolved
contracts/test/TestStrategy.sol Outdated Show resolved Hide resolved
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: breaking change

@fubuloubu
Copy link
Member

We are merging this and releasing 0.4.0 right?

@ghost
Copy link
Author

ghost commented May 16, 2021

We are merging this and releasing 0.4.0 right?

Yes please.

@fubuloubu fubuloubu merged commit 6159b87 into yearn:master May 16, 2021
orbxball pushed a commit to orbxball/yearn-vaults that referenced this pull request Aug 8, 2021
…earn#311)

* fix: inconsistent Liquidations in BaseStrategy Emergency Exit Mode

* refactor: move code back into harvest
sambacha pushed a commit to sambacha/yearn-vaults that referenced this pull request Sep 7, 2021
…earn#311)

* fix: inconsistent Liquidations in BaseStrategy Emergency Exit Mode

* refactor: move code back into harvest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Liquidations in BaseStrategy Emergency Exit Mode
1 participant