Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRP: Add keepVELO to strategy page fee UI for Velodrome vaults #310

Closed
dudesahn opened this issue Aug 1, 2023 · 0 comments · Fixed by #311
Closed

FRP: Add keepVELO to strategy page fee UI for Velodrome vaults #310

dudesahn opened this issue Aug 1, 2023 · 0 comments · Fixed by #311
Assignees

Comments

@dudesahn
Copy link
Contributor

dudesahn commented Aug 1, 2023

What is your proposal 🚀

A clear and concise description of what you are asking for.

  • To the right of "Performance Fee", add a field to visualize our keepVELO percentage and name it "keepVELO". This can be pulled from exporter in the fees, if it is a velodrome vault then it will report a keep_velo percentage (between 0 and 1) once this PR is merged in their repo: feat: add keep_velo to fees for ui usage yearn-exporter#568
  • Add a hover tooltip that explains what keepVELO is. Something like "Percentage of VELO locked in each harvest. This is used to boost Velodrome vault pools, and is offset via yvOP staking rewards."
Screen Shot 2023-08-01 at 8 29 09 AM

What does this solve ? 🛠

A clear and concise description about why this is a nice to have.

  • Although we already include keepVELO in our overall APR calc, it's nice that users can know exactly how much VELO is being kept by a vault. And the tooltip lets them know what it is, why we do it, and tells them they are getting more than enough to cover it in yvOP.

More 🔎

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🟢 Done
Development

Successfully merging a pull request may close this issue.

2 participants