feat: Add keepVELO to strategy page fee for Velodrome vaults #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Majorfi
requested changes
Aug 3, 2023
| @@ -283,7 +286,7 @@ details { | |||
| .tooltip:hover .tooltiptext { | |||
| @apply visible opacity-100; | |||
| } | |||
| .tooltip:hover .tooltipLight { | |||
There was a problem hiding this comment.
We also need to keep this one
Majorfi
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tooltipLightwas overflowing to the right;yDaemonVaultSchemaschema to includekeep_velo;Related Issue
Closes #310
Motivation and Context
Although we already include keepVELO in our overall APR calc, it's nice that users can know exactly how much VELO is being kept by a vault. And the tooltip lets them know what it is, why we do it, and tells them they are getting more than enough to cover it in yvOP.
How Has This Been Tested?
Ran locally, tested with vault
0x88B429359665B8685b7431f5A0f6e8C719Bf49Aawhich askeep_veloof 0.5Screenshots (if appropriate):
Web
No hover
On hover
Mobile