fixed the warning by deepscan

yeastgenome · Dec 10, 2019 · 15a6de9 · 15a6de9
1 parent c22885e
commit 15a6de9
Showing 1 changed file with 20 additions and 16 deletions.
diff --git a/src/js_src/containers/authorResponse/processOneResponse.js b/src/js_src/containers/authorResponse/processOneResponse.js
@@ -66,28 +66,32 @@ class ProcessOneResponse extends Component {
     });
   }
 
-  onChange4tag(newVal) {
-    this.setState({ has_fast_track_tag: newVal });
+  onChange4tag() {
+    this.setState(prevState=>({ 
+      has_fast_track_tag: !prevState.has_fast_track_tag 
+    }));
     this.onChange();
-    return 1;
   }
 
-  onChange4datasets(newVal) {
-    this.setState({ curator_checked_datasets: newVal });
+  onChange4datasets() {
+    this.setState(prevState=>({
+      curator_checked_datasets: !prevState.curator_checked_datasets 
+    }));
     this.onChange();
-    return 1;
   }
 
-  onChange4genelist(newVal) {
-    this.setState({ curator_checked_genelist: newVal });
+  onChange4genelist() {
+    this.setState(prevState=>({
+      curator_checked_genelist: !prevState.curator_checked_genelist 
+    }));
     this.onChange();
-    return 1;
   }
 
-  onChange4action(newVal) {
-    this.setState({ no_action_required: newVal });
+  onChange4action() {
+    this.setState(prevState=>({
+      no_action_required: !prevState.no_action_required 
+    }));
     this.onChange();
-    return 1;
   }
 
   onChange() {
@@ -117,16 +121,16 @@ class ProcessOneResponse extends Component {
     return (
       <div className='row'>
         <div className='columns medium-6 small-6'>
-          Has fast track tag? <input type="checkbox" name='has_fast_track_tag' value={this.state.has_fast_track_tag} checked={this.state.has_fast_track_tag} onChange={this.onChange4tag(!this.state.has_fast_track_tag)} />
+          Has fast track tag? <input type="checkbox" name='has_fast_track_tag' value={this.state.has_fast_track_tag} checked={this.state.has_fast_track_tag} onChange={this.onChange4tag} />
         </div>
         <div className='columns medium-6 small-6'>
-          Curator checked datasets? <input type="checkbox" name='curator_checked_datasets' value={this.state.curator_checked_datasets} checked={this.state.curator_checked_datasets} onChange={this.onChange4datasets(!this.state.curator_checked_datasets)} />
+          Curator checked datasets? <input type="checkbox" name='curator_checked_datasets' value={this.state.curator_checked_datasets} checked={this.state.curator_checked_datasets} onChange={this.onChange4datasets} />
         </div>
         <div className='columns medium-6 small-6'>
-          Curator checked genelist? <input type="checkbox" name='curator_checked_genelist' value={this.state.curator_checked_genelist} checked={this.state.curator_checked_genelist} onChange={this.onChange4genelist(!this.state.curator_checked_genelist)} />
+          Curator checked genelist? <input type="checkbox" name='curator_checked_genelist' value={this.state.curator_checked_genelist} checked={this.state.curator_checked_genelist} onChange={this.onChange4genelist} />
         </div>
         <div className='columns medium-6 small-6'>
-          No action required? <input type="checkbox" name='no_action_required' value={this.state.no_action_required} checked={this.state.no_action_required} onChange={this.onChange4action(!this.state.no_action_required)} />
+          No action required? <input type="checkbox" name='no_action_required' value={this.state.no_action_required} checked={this.state.no_action_required} onChange={this.onChange4action} />
         </div>
       </div>
     );