Skip to content

Commit

Permalink
Bugfix:Web: Get ReportedPeptideIds: NO PSM Filters & PSM has Decoy flag
Browse files Browse the repository at this point in the history
Bug in the common server side code to get Reported Peptide Ids for
PSM/Reported Peptide/... filters.

PROBLEM:

For When the filters NOT match the default filters
AND there are NO PSM Filters
AND the search contains PSMs with the Decoy flag:
the get Reported Peptide Ids will return Reported Peptide Ids where the
ONLY PSMs have the Decoy flag.

Changed so that if the Search has flag that it contains PSMs with Decoy
flag that the get Reported Peptide Ids when have NO PSM Filters it will
get the PSM count for each Reported Peptide Id.
  • Loading branch information
danjasuw committed May 15, 2024
1 parent c1dded7 commit de6befc
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,6 @@ public List<ReportedPeptide_MinimalData_List_FromSearcher_Entry> getPeptideData

sqlSB.append( SQL_FIRST_PART );


if ( ! proteinCutoffValuesList.isEmpty() ) {

// Filter on Protein Annotations. Subquery to remove duplicate reported_peptide_id
Expand Down Expand Up @@ -519,6 +518,10 @@ public List<ReportedPeptide_MinimalData_List_FromSearcher_Entry> getPeptideData

if ( ( ! resultList_Temp.isEmpty() )
&& ( ( psmCutoffValuesList != null && psmCutoffValuesList.size() > 1 )

// NO PSM Filters AND Search has PSMs that are Decoy
|| ( ( psmCutoffValuesList == null || psmCutoffValuesList.size() == 0 ) && searchFlagsForSearchIdSearcher_Result_Item.isAnyPsmHas_IsDecoy_True() )

|| ( modificationPositionCutoffValuesList != null && ( ! modificationPositionCutoffValuesList.isEmpty() ) )
|| minimumNumberOfPSMsPerReportedPeptide > 1 ) ) {

Expand Down

0 comments on commit de6befc

Please sign in to comment.