Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] make table optional #147

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Conversation

36000
Copy link
Contributor

@36000 36000 commented Apr 2, 2024

This makes afq insight dependent on hdf5, which requires installation (usually by conda). Without this, I believe afq-insight is entirely pip-installable, which is much more convenient for new users.

@coveralls
Copy link

Pull Request Test Coverage Report for Build fd48498305af8adef543c84c837247216948fd86-PR-147

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 6ad27c9955b6a0f1710179b3d72bb215bc8f2496: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@36000
Copy link
Contributor Author

36000 commented Apr 2, 2024

@arokem this is ready for review/merge

@arokem arokem merged commit cbf13cf into yeatmanlab:main Apr 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants