BF: Use Tableau 20 colors for the 20 waypoint-defined bundles. #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that we don't need 40 colors. This is only needed in AFQ-Browser because we need to be able to highlight the picked bundles. This means that the code can be simplified quite a bit. This commit also clarifies and simplifies the logic, including comments. And adds a docstring. Changes in the API module to remain consistent.
|
|
|
I find the white background to be slightly more visible. Anyone want to bike-shed with me?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247
It turns out that we don't need 40 colors. This is only needed in AFQ-Browser
because we need to be able to highlight the picked bundles.
This means that the code can be simplified quite a bit. This commit also
clarifies and simplifies the logic, including comments. And adds a docstring.
Changes in the API module to remain consistent.