Api File Naming

[36000]

Show session and subject in all file names. Moved common inclusions for file names into fname function. Some pep8 fixes.

[pep8speaks]

Hello @36000! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-24 20:13:40 UTC

[36000]

resolves #258

[36000]

@arokem if the dmriprep files already have the sub-XX_sess-XX prefix like in BIDs format shown below, then we do not need this pull request, the api already grabs this prefix from the file.
image
Should I use this PR to add in the sub-XX_sess-XX prefix if it doesn't exist, or should I drop this aspect of this PR all together?

[arokem]

Oh yeah - let's leave the output like the input. But in our own work, let's make sure the inputs are fully spelled out.

I think that means we can close this?

[36000]

No on closing. I also moved common inclusions for file names into the fname function. This won't change functionality but makes the code nicer. For example, Instead of having this in every function:

odf_model = self.tracking_params['odf_model']

directions = self.tracking_params['directions']

...

fname = fname + (

                f'_space-RASMM_model-{odf_model}'

                f'_desc-{directions}'

            )

You can instead use the include_track argument when you want to include that information in the file name:
self._get_fname(row, suffix, include_track=True)

[36000]

I rebased so now this PR only includes the convenient function and some pep8 fixes. However, #268 would use this function, so we should not merge both without updating and rebasing one on top of the other.

[arokem]

LGTM! I love it when a PR removes more lines of code than it adds :-)