Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added random_seed parameter in tractography #270

Merged
merged 3 commits into from
Jun 26, 2020

Conversation

36000
Copy link
Collaborator

@36000 36000 commented Jun 23, 2020

This parameter sets the random_seed when random_seeds is True.

@36000
Copy link
Collaborator Author

36000 commented Jun 23, 2020

@arokem Does the documentation always fail? Double check I updated everything correctly in the cli.json file before merging.

Copy link
Collaborator

@arokem arokem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to use the random seed that is passed in other places where randomness is used.

The one that immediately comes to mind is the ProbabilisticDirectionGetter on L104 below

AFQ/tractography.py Outdated Show resolved Hide resolved
@36000
Copy link
Collaborator Author

36000 commented Jun 24, 2020

For the ProbabilisticDirectionGetter, I believe that the random_seed set in local tracking is what it ends up using. I just set that to rng_seed.

@arokem
Copy link
Collaborator

arokem commented Jun 25, 2020

I think that you need to also add this parameter as an option in bin/pyAFQ

@36000
Copy link
Collaborator Author

36000 commented Jun 25, 2020

I think that you need to also add this parameter as an option in bin/pyAFQ

This is how segmentation parameters are handled in bin/pyAFQ:
image
I believe this means it is loaded from pyafq_cli.json ?

@arokem
Copy link
Collaborator

arokem commented Jun 26, 2020

No - pyafq_cli.json is here for boutiques

But I think that I was wrong. All the arguments get automatically read in https://github.com/yeatmanlab/pyAFQ/blob/master/bin/pyAFQ#L42

So I believe this is good to go.

@arokem arokem merged commit 67e5847 into yeatmanlab:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants