Extra requirements feature added, consistent with current requirement files #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should there be an extra_requirements folder to put potential new requirements in? |
|
@arokem what do you think of this setup? Should we do this or just replicate cloudknot i.e. get rid of requirement files. |
arokem
reviewed
Jul 2, 2020
|
To answer your question: we can merge this for now. Let's keep in mind that we might want to eventually switch to a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.py now looks for files of the form
'requirements-*.txt'and uses them for the EXTRAS_REQUIRE argument.Currently allows:
pip install 'pyAFQ[dev]'Automatically finds more extra setups when new files are added.
For example, if
requirements-fury.txtwere added, this would find that file and make a'pyAFQ[fury]'extra setup.