Adds a setup.cfg file and cleans up metadata and other hacks #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cruft. Hopefully addresses yeatmanlab#306, and also overall reduces the amount of hackiness.
|
Hello @arokem! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-07-27 01:21:16 UTC |
arokem
commented
Jul 26, 2020
| AUTHOR = "pyAFQ developers" | ||
| AUTHOR_EMAIL = "arokem@gmail.com" | ||
| PLATFORMS = "OS Independent" | ||
| SCRIPTS = [op.join('bin', op.split(f)[-1]) for f in glob.glob('bin/*')] |
There was a problem hiding this comment.
Still need to figure out how to replace this in the setup.cfg file
There was a problem hiding this comment.
I guess 6bbc360 is still an option.
|
I think this is GTG, so merging. |
This was referenced Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully addresses #306 along the way.